Skip to content

fix(qinq): declare IpamSVLAN name unique so the CVLAN HFID validates #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minitriga wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

fix(qinq): declare IpamSVLAN name unique so the CVLAN HFID validates #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/+qinq-svlan-name.fixed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
The QinQ extension now loads on Infrahub releases before 1.9. `IpamCVLAN` builds its HFID from its S-VLAN's name,
so `IpamSVLAN` now declares `name` unique; older releases rejected the schema with "HFID of IpamCVLAN refers to peer
IpamSVLAN with a non-unique combination of attributes".
2 changes: 2 additions & 0 deletions docs/docs/reference/qinq.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ This schema extension adds the Service VLAN and Customer VLAN nodes needed to mo
- **Namespace:** Ipam
- **Uniqueness Constraints:**
- vlan_id__value, vlan_group
- name__value
- **Inherit From:** IpamGenericVLAN

#### Relationships
Expand Down Expand Up @@ -64,6 +65,7 @@ nodes:
uniqueness_constraints:
- - vlan_id__value
- vlan_group
- - name__value
relationships:
- name: cvlan
peer: IpamCVLAN
Expand Down
1 change: 1 addition & 0 deletions extensions/qinq/qinq.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ nodes:
- IpamGenericVLAN
uniqueness_constraints:
- [vlan_id__value, vlan_group]
- [name__value]
relationships:
- name: cvlan
peer: IpamCVLAN
Expand Down
Loading