Repository navigation
chore(contract): regenerate types for the 1.27.0 journey descriptions - #64
Merged
Merged
Conversation
eralabs-ai/ora#1266 rewrote three journey descriptions in the served spec (hold the stream to its end; polling only reads what a stream saved) without a version bump, which turns the contract drift job red. Descriptions only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This regenerates
src/contract/types.gen.tsfrom the spec ora.ai serves now. ora #1266 rewrote the journey descriptions in that spec: they now say to hold the run stream open until itsresultorerrorframe, because polling only reads a run the stream already saved. The contract version stays 1.27.0 and no field or shape changes, so CLI output and exit codes are unchanged. This turns the "Contract drift vs production" job green again; it has been failing since #1266 deployed.Why
The drift job compares the generated types, descriptions included, with the production spec.
Checks
pnpm contract:genagainst production; only@descriptionlines changed.