Repository navigation
chore: bump Kotlin to 2.2.21 and drop nebula-api's 1.9.24 pin - #74
Merged
Merged
Conversation
Orbital, Taxi and Copilot are all on Kotlin 2.2.21, so nebula-api no longer needs to be compiled with 1.9 for older consumers. Removing the pin also fixes builds on JDK 25, which the 1.9.24 compiler can't parse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
👷 Deploy Preview for orbital-nebula processing.
|
✅ Deploy Preview for orbital-nebula canceled.
|
nebula-dsl declared ktor-server-netty-jvm and ktor-server-core-jvm twice, and nebula-runtime declared ktor-server-core-jvm twice. Maven 3 only warned about this, but CI now fails while reading the POMs. The copies we keep get the same version (2.3.12) from the Ktor BOM. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
kotlin.versionin the root POM from 2.2.0 to 2.2.21, matching Orbital (vyne), Taxi and Copilot.Remove the
kotlin.version1.9.24 override fromnebula-api. It was there for consumers still on Kotlin 1.9, and none are left.kotlin-stdlibstaysprovided.Update the Kotlin version in
CLAUDE.md.Remove duplicate Ktor dependency declarations in
nebula-dslandnebula-runtime. CI (andmain) now fail on these when reading the POMs, where they used to be warnings. The copies we keep get the same version, 2.3.12, from the Ktor BOM.This also fixes builds on JDK 25: the 1.9.24 compiler couldn't parse the
25.0.4Java version string.Testing
mvn clean test-compilepasses locally on JDK 25.0.4.nebula-dsl: 62 of 63 tests pass, 1 skipped. The one error is the Oracle case inSqlExecutorTest: thegvenzl/oracle-xecontainer (amd64-only) doesn't start on an arm64 Mac. It fails the same way onmainwith JDK 21, so this change didn't cause it.nebula-runtime(19 passed, 1 skipped) andnebula-cli(5 passed) pass locally on JDK 21.StreamStacksCompilationErrorTestinnebula-runtimeerrors because the Byte Buddy version Mockito pulls in only supports up to Java 22. That comes from JDK 25 itself, not this change, and won't affect CI on JDK 21. Upgrading Mockito/Byte Buddy is a separate follow-up if we want local builds on JDK 25 to be fully green.🤖 Generated with Claude Code