Repository navigation
test: require the full Chromium in the playwright feature tests - #27
Merged
Merged
Conversation
The old check grepped the browsers directory for "chromium", which the headless shell's directory alone satisfies. Assert the full browser binary instead, since headed runs and the sandbox's remote browser need it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCDUvJ2D9CySZKiuBKRmx9
|
Automatic reviews are disabled for this repository. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VCDUvJ2D9CySZKiuBKRmx9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The playwright feature's tests checked
ls /usr/local/share/ms-playwright | grep -q chromium, which thechromium_headless_shell-*directory alone satisfies. If a future Playwright stopped downloading the full browser, the tests would still pass, while headed runs and the sandbox's remote browser (which looks forchromium-*/chrome-linux*/chrome) would break.Both scenarios now assert that the full browser binary exists and is executable at
chromium-*/chrome-linux*/chrome(chrome-linux64on amd64,chrome-linuxon older and arm64 builds).Test-only change:
install.shis untouched, so there's no feature version bump. I checked the glob against a real browsers directory: it matches the full install and fails on a directory that has only the headless shell, which the old grep let through.🤖 Generated with Claude Code
https://claude.ai/code/session_01VCDUvJ2D9CySZKiuBKRmx9
Generated by Claude Code
Note
Low Risk
Test-only assertion changes with no install or runtime behavior modified.
Overview
Tightens Playwright feature tests so they fail if only the headless Chromium shell is installed, not the full browser.
Both
ubuntu.shandubuntu_no_node.shreplace a directory-namegrep chromiumcheck with a sharedfull_chromium()helper that requires an executable atchromium-*/chrome-linux*/chromeunderPLAYWRIGHT_BROWSERS_PATH. That matches what headed runs and the remote browser path expect, so a future install that dropped the full browser would no longer slip through tests.Reviewed by Cursor Bugbot for commit d38726d. Configure here.