Skip to content

NO-ISSUE: assign VMaaS QE code ownership - #2467

Merged
prabinovRedhat merged 1 commit into
osac-project:mainfrom
prabinovRedhat:no-issue/add-wg-qe-ui-codeowners
Nov 17, 2026
Merged

prabinovRedhat merged 1 commit into
osac-project:mainfrom
prabinovRedhat:no-issue/add-wg-qe-ui-codeowners

Conversation

@prabinovRedhat

@prabinovRedhat prabinovRedhat commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Assign @osac-project/wg-qe to the five requested osac-ui paths.
  • Keep the existing @osac-project/wg-ui ownership for the rest of osac-ui.
  • More-specific rules take precedence over the broad /osac-ui/ rule.

Jira

N/A

Related

Test plan

  • pre-commit run --files CODEOWNERS
  • git diff --check
  • Verify code-owner assignment with a test PR after merge

This PR description was drafted with AI assistance (create-pr v0.2.0). Review for accuracy.

Summary of changes

Affected area: Repository ownership only. The change edits CODEOWNERS and does not touch code, APIs, controllers, databases, authentication, deployment, CI pipelines, or documentation.

File changed: CODEOWNERS (+6 lines, 0 removed; 1 file changed).

What changed: The diff adds a comment line and five path rules after the existing /osac-ui/ @osac-project/wg-ui rule:

  • /osac-ui/apps/e2e-tests/ → @osac-project/wg-qe
  • /osac-ui/apps/playwright/ → @osac-project/wg-qe
  • /osac-ui/libs/locators/ → @osac-project/wg-qe
  • /osac-ui/libs/test-utils/ → @osac-project/wg-qe
  • /osac-ui/libs/osac-cli/ → @osac-project/wg-qe

The broad /osac-ui/ rule still assigns the rest of osac-ui to @osac-project/wg-ui. The more specific rules assign the five paths to @osac-project/wg-qe. CODEOWNERS uses last-match precedence, so these later rules take effect for matching paths.

Backward compatibility: No code or API changes. Review routing changes for the five paths. Pull requests that touch those paths will request review from wg-qe instead of wg-ui.

Dependencies and open items:

  • The PR depends on NO-ISSUE: add VMaaS QE team memberships github-config#299 for team membership. The wg-qe team must exist and contain the required members for the owner assignments to resolve.
  • The PR description reports that pre-commit run --files CODEOWNERS and git diff --check passed. Those results come from the PR description, not from a run in this review.
  • The PR description leaves verification of code-owner assignment with a test PR unchecked.
  • The PR references no Jira issue.

Alterations to exported or public entities: None.

Review effort: Low.

Risk classification

Not available. The supplied context does not include the labeling instructions that define risk:ship, risk:show, and risk:ask. No label is assigned, and no criteria are cited.

Assign the VMaaS QE team to the five osac-ui test and helper paths.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: prabinov <prabinov@redhat.com>
@prabinovRedhat
prabinovRedhat requested a review from a team as a code owner November 16, 2026 14:46
@openshift-ci-robot

Copy link
Copy Markdown

@prabinovRedhat: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

  • Assign @osac-project/wg-qe to the five requested osac-ui paths.
  • Keep the existing @osac-project/wg-ui ownership for the rest of osac-ui.
  • More-specific rules take precedence over the broad /osac-ui/ rule.

Jira

N/A

Related

Test plan

  • pre-commit run --files CODEOWNERS
  • git diff --check
  • Verify code-owner assignment with a test PR after merge

This PR description was drafted with AI assistance (create-pr v0.2.0). Review for accuracy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@osac-ci

osac-ci Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Tip

🚦 CI status

Passed   Approval: approved by coderabbitai[bot], omer-vishlitzky, talhil-rh on cc24155
Passed   Code owners: @osac-project/wg-infra (all approved)
Passed   CI: passed
Passed   Jira reference: passed
Passed   E2E: Passed: vmaas, caas, bmaas
Passed   Auto-merge: on (the pull request is in the merge queue)
Pending   Merge queue: in the queue (position 3, checks are running)

🧪 E2E tests · Passed 3 passed · Not applicable 3 not run · run them now (7 available)

Who: any member of the organization, on any pull request (a draft, a fork or your own).

How to start a suite:

  • Check a box below. The box clears itself.
  • Or comment /test for the suites this change needs.
  • Or comment /test <suite> for the ones you name (the ids are in the boxes below).

Good to know: suites run on the head commit cc24155. A suite you ask for runs again, whatever it ended with. If it is running, the same ask does nothing; asking for another version of it stops that run and starts the one you asked for.

  • VMaaS Full Install · Passed passed (run)
  • CaaS Full Install · Passed passed (run)
  • CaaS Full Install · sanity + regression · Not applicable not run on this commit
  • BMaaS Full Install · Passed passed (run)
  • BMaaS Netris Full Install · Not applicable not run on this commit
  • VMaaS Netris Full Install · Not applicable not run on this commit
  • Stretched Netris Full Install · Not applicable not run on this commit
History · 6 runs
  • 2026-11-16 14:49 UTC · BMaaS Full Install · Passed passed (run)
  • 2026-11-16 14:49 UTC · CaaS Full Install · default · Passed passed (run)
  • 2026-11-16 14:49 UTC · VMaaS Full Install · Passed passed (run)
  • 2026-11-16 14:49 UTC · BMaaS Full Install · Closed stopped, replaced by another run (run)
  • 2026-11-16 14:49 UTC · CaaS Full Install · default · Closed stopped, replaced by another run (run)
  • 2026-11-16 14:49 UTC · VMaaS Full Install · Closed stopped, replaced by another run (run)

How suites are started by hand · The status is refreshed when CI starts or ends, a review, auto-merge or the merge queue changes, or someone comments · osac-ci

@coderabbitai

coderabbitai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review.

Walkthrough

CODEOWNERS adds VMaaS QE ownership for the osac-ui E2E tests, Playwright tests, locators, test utilities, and CLI paths.

Changes

QE ownership rules

Layer / File(s) Summary
Assign QE path ownership
CODEOWNERS
Adds ownership rules for five osac-ui paths: E2E tests, Playwright tests, locators, test utilities, and the CLI.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested labels: risk:ask

Suggested reviewers: eliorerz

Merge Risk: Minimal · up to cc241

This change assigns QE ownership to five osac-ui test and CLI paths. It has no runtime impact. The only remaining step is to confirm team access after merge, as the author already plans.

Pre-merge checks: Passed 10

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "NO-ISSUE: assign VMaaS QE code ownership" matches the changeset. The CODEOWNERS diff adds @osac-project/wg-qe as owner for five osac-ui E2E, Playwright, locator, test utility, and CLI paths…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
No-Sensitive-Data-In-Logs Passed The check is about logging that exposes secrets, tokens, keys, session IDs, internal hostnames, or customer/PII data. The pull request changes one file, CODEOWNERS (+6/-0). It adds five `@osac-project…
No-Hardcoded-Secrets Passed The pull request changes one file, CODEOWNERS (+6 lines). The added lines are five path-to-team ownership rules under /osac-ui/ and assign @osac-project/wg-qe. They contain no API keys, tokens, passwo…
No-Weak-Crypto Passed The no-weak-crypto check does not apply to this pull request. The changed-file inventory shows one modified file, CODEOWNERS. The patch adds only code-owner rules that assign @osac-project/wg-qe t…
No-Injection-Vectors Passed The check is inapplicable to this change. The PR modifies only CODEOWNERS (one file, M). The patch adds five path-ownership rules that assign /osac-ui/apps/e2e-tests/, `/osac-ui/apps/playwright/…
Container-Privileges Passed The check is container-privileges. It applies to container and Kubernetes manifests that set privileged mode, host namespaces, dangerous capabilities, root execution, or privilege escalation. The pull…
Ai-Attribution Passed AI tools were used. The PR description says it was "drafted with AI assistance (create-pr v0.2.0)", and the single commit (cc24155) is attributed to AI. The commit message contains the trailer `Assis…
Full details: Title check

Explanation

The title "NO-ISSUE: assign VMaaS QE code ownership" matches the changeset. The CODEOWNERS diff adds @osac-project/wg-qe as owner for five osac-ui E2E, Playwright, locator, test utility, and CLI paths. The title names the main change, the team, and the area. The "NO-ISSUE" prefix reflects that no Jira issue is referenced, which the PR objectives note.

Full details: No-Sensitive-Data-In-Logs

Explanation

The check is about logging that exposes secrets, tokens, keys, session IDs, internal hostnames, or customer/PII data. The pull request changes one file, CODEOWNERS (+6/-0). It adds five @osac-project/wg-qe ownership rules for osac-ui E2E, Playwright, locators, test-utils and CLI paths. It adds no source code, test code, or logging statements, so no logging behavior is introduced or changed. The check is therefore inapplicable and passes.

Full details: No-Hardcoded-Secrets

Explanation

The pull request changes one file, CODEOWNERS (+6 lines). The added lines are five path-to-team ownership rules under /osac-ui/ and assign @osac-project/wg-qe. They contain no API keys, tokens, passwords, private keys, base64 blobs, URLs with embedded credentials, or credential-named variables assigned string literals. The no-hardcoded-secrets condition is not triggered.

Full details: No-Weak-Crypto

Explanation

The no-weak-crypto check does not apply to this pull request. The changed-file inventory shows one modified file, CODEOWNERS. The patch adds only code-owner rules that assign @osac-project/wg-qe to five osac-ui test and helper paths. A case-insensitive search of the patch for MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, HMAC, cipher, crypto, and comparison terms returned no matches. The PR introduces no cryptographic code, no secret or token comparison, and no weak algorithm. The PR author is prabinovRedhat, per the provider-reported record. The author field does not affect this check.

Full details: No-Injection-Vectors

Explanation

The check is inapplicable to this change. The PR modifies only CODEOWNERS (one file, M). The patch adds five path-ownership rules that assign /osac-ui/apps/e2e-tests/, /osac-ui/apps/playwright/, /osac-ui/libs/locators/, /osac-ui/libs/test-utils/, and /osac-ui/libs/osac-cli/ to @osac-project/wg-qe. The file contains no SQL, shell execution, eval/exec, deserialization, YAML loading, os.system, or HTML injection code. No injection vector is introduced. The jq exception is not relevant because no jq code changes.

Full details: Container-Privileges

Explanation

The check is container-privileges. It applies to container and Kubernetes manifests that set privileged mode, host namespaces, dangerous capabilities, root execution, or privilege escalation. The pull request changes one file, which is CODEOWNERS (git diff --name-status shows only M CODEOWNERS). The change adds code-owner rules for VMaaS QE paths under osac-ui. It adds no container, pod, or Kubernetes manifest content, so no failure condition applies. The check is inapplicable and passes.

Full details: Ai-Attribution

Explanation

AI tools were used. The PR description says it was "drafted with AI assistance (create-pr v0.2.0)", and the single commit (cc24155) is attributed to AI. The commit message contains the trailer Assisted-by: Codex &lt;noreply@openai.com&gt;, which meets the Assisted-by or Generated-by requirement. The commit has no Co-Authored-By trailer, so the prohibited AI co-author form is absent. The primary PR author is prabinovRedhat (status verified). The check passes.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: osac-project/osac
  • Branch: main
  • File: .coderabbit.yaml
  • Commit: 032e75e
  • Layers: Repository YAML (base), Central YAML (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: fce0df33-7c33-4e60-80a3-02ed0c00a7d2
Commits

Reviewing files that changed from the base of the PR and between 032e75e and cc24155.

Files selected for processing: 1

  • CODEOWNERS

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@osac-ci
osac-ci Bot enabled auto-merge November 16, 2026 15:07
@osac-ci
osac-ci Bot added this pull request to the merge queue Nov 16, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 16, 2026
@prabinovRedhat
prabinovRedhat added this pull request to the merge queue Nov 17, 2026
Merged via the queue into osac-project:main with commit 7d20a69 Nov 17, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants