You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove unused InjectTraceContext and InjectTraceContextToHeader in internal/telemetry/tracing/propagation.go; nats-client already injects trace context on publish.
Use errors.Is instead of err == jetstream.ErrNoKeysFound in internal/controller/enrollment/watcher.go:185 and accept.go:200.
Pass the caller's context through notify.Watcher.detectTransitions (internal/controller/notify/watcher.go:221-291) instead of context.Background().
Confirm callers of Server.Stop(ctx) (internal/controller/api/server.go:138-154) do not assume the drain has finished when it returns.
GetAgentTimeline treats every KV error as "no events", hiding real backend failures.
parseFileMode (internal/provider/file/deploy.go:174-187) silently falls back to 0644 on an unparsable mode.
Replace the bubble sort in internal/job/client/jobs.go:634-640 with sort.Slice.
Broadcast collection snapshots expected agents before publishing (internal/job/client/client.go:434,461), so an agent joining in that window is not counted.
Enrollment accept and reject find the pending agent by scanning every key (findPendingBy in internal/controller/enrollment/accept.go:194-223). Fine at today's scale; add a comment or an index if pending queues grow.
Stale doc comment in internal/cli/raw_output.go:37-39 about single-host output.
Found in the September 2026 codebase review. Tracked in the review tracking issue.
InjectTraceContextandInjectTraceContextToHeaderininternal/telemetry/tracing/propagation.go;nats-clientalready injects trace context on publish.errors.Isinstead oferr == jetstream.ErrNoKeysFoundininternal/controller/enrollment/watcher.go:185andaccept.go:200.notify.Watcher.detectTransitions(internal/controller/notify/watcher.go:221-291) instead ofcontext.Background().Server.Stop(ctx)(internal/controller/api/server.go:138-154) do not assume the drain has finished when it returns.GetAgentTimelinetreats every KV error as "no events", hiding real backend failures.parseFileMode(internal/provider/file/deploy.go:174-187) silently falls back to 0644 on an unparsable mode.internal/job/client/jobs.go:634-640withsort.Slice.internal/job/client/client.go:434,461), so an agent joining in that window is not counted.internal/provider/network/netplan/dns/debian_update_resolv_conf_by_interface.go:96usescontext.TODO().findPendingByininternal/controller/enrollment/accept.go:194-223). Fine at today's scale; add a comment or an index if pending queues grow.internal/cli/raw_output.go:37-39about single-host output.Found in the September 2026 codebase review. Tracked in the review tracking issue.