refactor(user): the caller names the resource, so the validator does not

[retr0h]

The piece deliberately left out of #575. 6 files.

validateAccountName took a kind argument purely to put "user" or "group" into its message, and every one of its twelve callers then wrapped the result with that same word:

group: invalid group name "Invalid": must match ...
user: invalid user name "john:root": must match ...

Dropping the parameter gives:

group: name "Invalid" must match ^[a-z_][a-z0-9_-]*\$?$ and be at most 32 characters
ssh key: add: name "Invalid" must match ...

That is the rule the rest of #565 settled on: only the outermost frame names the operation. It is also the rule that would have prevented the four doubled-prefix mistakes this work hit along the way.

Why it was separate

It changes a function signature, which is a different kind of change from rewording a string. The signature is unexported and has twelve call sites all inside internal/provider/node/user, so nothing outside the package moves.

Checks

go vet ./internal/provider/node/user/ clean. go test -count=1 ./internal/provider/... is 25 packages, 0 failures.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         501      501           
  Lines       24073    24072    -1     
=======================================
- Hits        24063    24062    -1     
  Misses         10       10           

Files with missing lines	Coverage Δ
internal/provider/node/user/debian_group.go	100.00% <100.00%> (ø)
internal/provider/node/user/debian_ssh_key.go	100.00% <100.00%> (ø)
internal/provider/node/user/debian_user.go	100.00% <100.00%> (ø)
internal/provider/node/user/validate.go	100.00% <100.00%> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54fd63c...9bd6d53. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.