fix: verify the site formatter and build the ui first - #131
Merged
Merged
Conversation
Three merged security fixes each edited pages under docs/ and left five of them unformatted, so Docusaurus Lint failed on main until osapi-io/osapi#512. The skill's verify gate listed just ready and just test, and neither covers the site: md-fmt excludes docs/ because Prettier owns that tree. Also records the fresh-worktree ordering. just ready lints before it builds the UI, so in a new worktree the linter cannot import the embed package and reports a typecheck error on a file nobody touched, which cost two gate runs to recognise. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two things the skill's verify gate was missing, both learned by getting them wrong this week.
The site formatter is not in
just readyorjust test.md-fmtexcludesdocs/because Prettier owns that tree viajust docusaurus-fmt. Three merged security fixes each edited a feature page, a CLI page or the configuration reference, passed both gates locally, and left main'sDocusaurus Lintred froma48daffe8until osapi-io/osapi#512. Step 5 now runsjust docusaurus-fmt-check, and says why.just readylints before it builds the UI. In a fresh worktreeui/dist/is empty, so golangci-lint cannot import the//go:embedpackage and reportstypecheckoncmd/controller_setup.go— a file the change never touched. That cost two gate runs to recognise, twice. Step 5 now starts withjust react-build.Both are the skill's own correction rule applied to itself: fix the guidance in its own change, before continuing the work that found it.
🤖 Generated with Claude Code
https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c