docs(osapi): plan the per-agent public key store - #134
Merged
Merged
Conversation
Store the accepted key in the existing enrollment bucket under a second prefix, keyed by machine ID, written only at acceptance. Verify job responses and registrations against it, and keep unverified registrations out of target resolution so a hostname cannot be claimed by a machine that never enrolled under it. Rotation mirrors the controller key: a superseded key with an expiry instant, not a duration. Enforcement uses the PKI flags that already exist and already claim to cover signing, so no new knob appears and an upgrade changes nothing until an operator turns it on. No constitution violations, so Complexity Tracking is omitted. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 for
002-agent-key-store: plan, research, data model, contract, quickstart.Key decisions
accepted.prefixVerifyWithGraceandRotationGracePeriodfor the controller key — one rotation concept, not two. An instant means a restart cannot extend the window.ControllerPKI.EnabledandAgentPKI.Enabledalready say they cover signing. This makes that true rather than adding a third state.One thing worth a reviewer's eye:
AgentRegistrationalready carries aFingerprintthe agent fills in itself, and nothing checks it. That self-reported field is the shape of GHSA-j73r. The plan treats the stored key as the authority and the fingerprint as a claim that must match it.Rejected, recorded in research.md: storing the key on the registration record (the attacker would supply their own validator), a new dedicated bucket, a key-history list, and no grace period.
Constitution check passes on all five principles, so Complexity Tracking is omitted rather than left empty.
Next:
/speckit-tasks.🤖 Generated with Claude Code