docs(osapi): break the agent key store into tasks - #135
Merged
Merged
Conversation
Organise the per-agent public key store into 41 tasks across the spec's three user stories, with every cited path verified against the osapi tree. US1 closes GHSA-3jh4's deferred response-verification half, US2 closes GHSA-j73r, and US3 adds rotation and removal so enforcement does not become a reason to switch verification back off. US1 and US2 are independent and either can ship first. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c
|
Thank you for contributing to this project! 😊🕹️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 output for
components/osapi/specs/002-agent-key-store: 41 tasksorganised by the spec's three user stories.
causes, the cache invalidated on write and remove, and acceptance as the only
writer. Blocks everything else.
Closes GHSA-3jh4's deferred half.
ignore unverified ones and resolve a contested hostname deterministically.
Closes GHSA-j73r.
full gate, and adding the fix to both advisories.
US1 and US2 are independent: both read the store, neither writes it, and they
touch different files.
Every file path in the task list was checked against the osapi tree rather than
taken from the plan. That caught two corrections — the canonical-serialisation
helper is a new
internal/job/registration.gowhile the struct itself lives ininternal/job/types.go, and the key-held fields belong onAgentInfo, notAgentRegistration, sinceAgentInfois whatListAgentsreturns.Gate:
just testgreen (mdformat, just-fmt, skill-lint).🤖 Generated with Claude Code
https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c