Repository navigation
Issue #190 solved: remove dead code left over from the Rust migration - #250
Open
PRINCEKK122 wants to merge 1 commit into
Open
PRINCEKK122 wants to merge 1 commit into
PRINCEKK122 wants to merge 1 commit into
Conversation
…gration Four things in the tree that nothing compiles or references: relay/src/ipc.rs is 113 lines behind a commented-out `// mod ipc;` in main.rs. relay/src/channel.rs is 6 lines that were never declared as a module at all. Neither is part of the crate, so neither is compiled. src/clientserver is a crate that cannot build: its Cargo.toml declares binaries at src/server.rs and src/client.rs, and neither file exists. Nothing references the crate. src/client.rs at the repo's src/ root is the orphan those binary paths were presumably meant to point at. The live IPC types are ToIpcThreadMessage and FromIpcThreadMessage in message.rs, which are untouched; the deleted ipc.rs is a separate unreferenced module. relay, src/server and baton all build, and the relay's test results are unchanged: 21 passed, 2 failed, the two failures being the mirror tests from oss-slu#247 that also fail on clean main here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #190.
What was dead
relay/src/ipc.rs(113 lines)// mod ipc;inmain.rs, so it is not part of the crate and is never compiledrelay/src/channel.rs(6 lines)src/clientserver/Cargo.tomldeclares binaries atsrc/server.rsandsrc/client.rs; neither file exists, so the crate cannot build. Nothing references itsrc/client.rssrc/root, referenced only by those broken binary pathssrc/clientserveris worth calling out:cargo checkinside it fails withcan't find bin 'server'. It has been unbuildable, not merely unused.What was kept
The live IPC types are
ToIpcThreadMessageandFromIpcThreadMessageinrelay/src/message.rs, used by the IPC thread instate.rs. Those are untouched. The deletedipc.rsis a separate, unreferenced module that happens to share the name.The
channel::references instate.rsandbichannel.rsare allcrossbeam::channel, the external crate, not the deleted local module.Testing
relay: 21 passed, 2 failed — unchanged from cleanmain. The two failures area_slow_python_reader_does_not_pace_imotionsanda_python_process_that_stops_reading_is_dropped_not_waited_on, both from Mirror the relay's packets to a second destination for Python #247, and both fail onmainhere too. I will raise that separately; it is not caused by this change.src/server: 5 passed.baton: builds.