Repository navigation
Conversation
… for oss_dev_analytics
There was a problem hiding this comment.
Thanks Justin, and welcome aboard. This is the most complete roster handling of the four tech lead PRs currently open. All four files in src/data/people/ are updated consistently, Hazel Caballero is properly moved to prevTechLeads.json, and the four developers you retired are correctly moved to prevDevelopers.json. That is the pattern I want everyone following.
Two structural items and then some cleanup.
Enroll Dash points at the wrong repository
docs/projects/enroll_dash/about.md lists Source Code as https://github.com/oss-slu/oss-orb, which is the ORB repo. This looks copy-pasted from the ORB page you created in the same PR.
There is no oss-slu/enroll_dash repo yet, so either point this at the real repo once it exists or mark it TBD for now. Please do not leave it pointing at ORB.
New projects need a Projects.json entry
Neither enroll_dash nor oss_orb was added to src/data/projects/Projects.json, so neither will appear as a card in the portfolio view. A new project needs all three of:
docs/projects/<slug>/about.md- an entry in
src/data/projects/Projects.json - an entry in
sidebars.js
You have 1 and 3. Please add 2. Note that the card image field will want a file in static/img/projects/.
Sidebar ordering
The Active Products list in sidebars.js is alphabetical by slug. Both new entries were appended to the end after wheres_religion_mobile. Please move enroll_dash up near the top and oss_orb in after oss_infra_ops.
Cleanup
https://github.com/tbdis a real GitHub account, not a placeholder. Please leave the developer entry as plainTBDwith no link.- Typo in the Enroll Dash overview: "repoorting" should be "reporting". There is also trailing whitespace at the end of that line.
- Typo on the ORB page: "UC Santa Cruz OPSO" should be "OSPO" (Open Source Program Office).
Hazel Caballero (prior tech lead)should be(alumni, prior tech lead)to match the convention used across the other project pages.- Client naming: our client for Enroll Dash is Enrollment Services rather than "SLU's Enrollment Office." Ryan Klotz is the right contact.
|
Thanks Daniel! The most recent commit should address everything in your comment. See you tomorrow |
|
Also, there's an enroll-dash repo, not enroll_dash |
Signed-off-by: Justin DeKock <jdekock17@gmail.com>
…repoexplorer (fork), added license to oss_dev_analytics
|
Hey Daniel - hope you start feeling better soon! I just pushed a new commit with a few changes I wanted to point out/clarify:
** I forgot to update the sidebars.js file with the new names, doing that now |
|
Fixed the sidebars.js issue, all checks are passing! It was pretty awesome how close alphabetically both the project name changes were |
|
Updated Projects.json and repo images. I THINK that should be everything |
added about.md for enroll_dash and oss_orb, added myself as tech lead for oss_dev_analytics