Skip to content

feat: ✨ Add live diagnostics and bounded profile capture - #93

Open
oxspan wants to merge 5 commits into
developfrom
feature/next-operations
Open

oxspan wants to merge 5 commits into
developfrom
feature/next-operations

Conversation

@oxspan

@oxspan oxspan commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Why

Operators need to inspect requests that are still running and obtain Agent thread dumps, while large profile captures currently require repeated launches and prefix validation. Time-zone metadata and local file failures also need clearer diagnostics for automation.

Changes

  • Add agent active-requests and agent thread-dump, with strict response parsing, string IDs, explicit partial/unavailable results and opt-in request names.
  • Add profile capture --max-total-pages, retaining initial integrity validation and transaction IDs in one process, with per-page checkpoints, bounded shutdown handling, writer exclusion and manifest-change detection.
  • Add live timezoneCheck reporting without changing saved capture formats; report safe local I/O exception categories without exposing paths or raw messages.
  • Patch compatible build/test dependencies and reject absolute archive members before package installation checks. Extract Agent request builders and shared settings decoding from the transport class.

Validation

  • Linux: all 321 tests passed, line coverage 94.97%, branch coverage 81.06%, coverage floors and command package input checks passed. Exact-head Linux/Windows validation: workflow run.
  • Windows: all 322 XML testcases passed, including packaged recovery and JFR read measurements; canonical command package inputs and native Windows bundle checks passed. The linked exact-head workflow completed successfully on both platforms.
  • Actual Collector/Agent diagnostics on 2.8.1 with Java8 and locally built 2.21.3 with Java21, including held-request stack traces and transaction-ID correlation.
  • Patched Spring HTTP/JDBC instrumentation and offline capture/search/summary/comparison; Java8 legacy JDBC with H2 2.2.224.
  • Native Windows file-sharing denial, preserved checkpoint and successful resume; actual SIGINT checkpoint preservation and writer-lock release.
  • Windows recovery page snapshots select page files before reading, so the in-flight writer's exclusive coordination handle is not read; existing checkpoint and page-byte assertions remain intact. The same packaged recovery test failed before this fixture correction and passed afterward.
  • File-backed 400-page measurement reduced existing-page reads from 475,556,088 to 10,561,786 bytes. This synthetic local measurement is not production Collector throughput or a universal speedup claim.

Compatibility and limits

Saved capture formats and default page budgets are unchanged. New live fields are additive. Thread dumps intentionally contain raw diagnostic text. Writer coordination applies within one platform; do not mix Windows and Linux writers on a WSL-shared directory.

Reported time-zone agreement does not verify Collector storage partitions. The original uncontrolled Windows incident remains unconfirmed. Two Spring MVC advisories have no public Framework6.2 patch; the test-only loopback fixture does not enable their affected features. See the testing and inspection guides for scope.

Refs #57, #58. This PR does not close either issue or publish a release.

@github-actions

Copy link
Copy Markdown
Contributor

Linux CI: success · Commit 3f9ab8c

Test results (Linux)

Total Passed Failed Errors Skipped
321 321 0 0 0

Test coverage

Metric Covered / total Coverage Minimum Result
LINE 2471 / 2602 94.97% 90.00% PASS
BRANCH 1494 / 1843 81.06% 80.00% PASS

Includes the test JVM and CLI subprocesses. Excludes optional real-Collector smoke tests.

Workflow logs and report artifacts

Updated on each CI run. Windows checks, when required, are reported separately in the workflow.

@oxspan
oxspan marked this pull request as ready for review November 15, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant