perf: enhance tokens block memory usage - #486
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 71.12% 71.01% -0.11%
==========================================
Files 232 232
Lines 18404 18544 +140
==========================================
+ Hits 13089 13169 +80
- Misses 4337 4391 +54
- Partials 978 984 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@seqbenchbot start search-regular main 'k8s_pod:-eu-' --duration 5m |
|
Nice, @dkharms Started benchmark Show details
I'll post the statistics here once it finishes. Here is a list of helpful links: Have a great time! |
|
Nice, @dkharms Benchmark Show summary
Compare it against another run with |
|
@seqbenchbot start search-regular 0-enhance-token-block-memory 'k8s_pod:-eu-' --duration 5m |
|
Nice, @dkharms Started benchmark Show details
I'll post the statistics here once it finishes. Here is a list of helpful links: Have a great time! |
|
Nice, @dkharms Benchmark Show summary
Compare it against another run with |
Description
Measurements
Memory
Memory reduction (prod fraction):
message:*foobar*25335032 => 20584912 bytes
message:*87466437*71844952 => 58236912
Query perf
V5 fractions
For V5 fractions (current version) we have same cold perf - unpack is unchanged, same hot perf for
containswildcard but a little slowdown for wildcards like suffix sinceGetTokenis now includes version check and it's a bit more expensive. Please see the code of Block andcontainsfunction.message:*eldorado*request:*010462589104432*request:*201928699403000V6 fractions
For V6 (new format) we have slightly better cold perf - unpack is more cheap. For hot queries it's also slightly faster for contains wildcards since getting a token is a bit more cheap. Same for arbitrary wildcards - slightly more expensive
GetToken, I suppose.message:*eldorado*request:*010462589104432*request:*201928699403000