Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/app/mw/error_type.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const (
respServerError
)

const unknownError = "unknown error"

// gRPCRespErrorTypeFromStatusCode returns response error type depending on gRPC status code.
func gRPCRespErrorTypeFromStatusCode(statusCode codes.Code) respErrorType {
switch statusCode {
Expand All @@ -36,3 +38,10 @@ func httpRespErrorTypeFromStatusCode(statusCode int) respErrorType {
return respServerError
}
}

func processErrorMessage(err string) string {
if err == "" {
return unknownError
}
return err
}
19 changes: 11 additions & 8 deletions internal/app/mw/grpc_mw.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,17 @@ func GRPCLogInterceptor(l *tracing.Logger) grpc.UnaryServerInterceptor {
if err != nil {
l.Error(ctx, "failed to marshal request message", zap.Error(err))
}

reqLogArgs := requestLogArgs{
component: "gRPC",
header: md,
fullMethod: info.FullMethod,
requestBody: string(rBody),
}
if userName, err := types.GetUserKey(ctx); err == nil {
reqLogArgs.user = userName
}

logRequestBeforeHandler(ctx, l, reqLogArgs)

start := time.Now()
Expand All @@ -52,15 +57,13 @@ func GRPCLogInterceptor(l *tracing.Logger) grpc.UnaryServerInterceptor {

errType := gRPCRespErrorTypeFromStatusCode(st.Code())

if errType == respClientError {
reqLogArgs.clientError = st.Err().Error()
}
if errType == respServerError {
reqLogArgs.serverError = st.Err().Error()
}
if userName, err := types.GetUserKey(ctx); err == nil {
reqLogArgs.user = userName
switch errType {
case respClientError:
reqLogArgs.clientError = processErrorMessage(st.Err().Error())
case respServerError:
reqLogArgs.serverError = processErrorMessage(st.Err().Error())
}

if details := st.Details(); len(details) > 0 {
reqLogArgs.details = details
}
Expand Down
15 changes: 5 additions & 10 deletions internal/app/mw/http_mw.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,16 +77,11 @@ func HTTPLogInterceptor(l *tracing.Logger) func(next http.Handler) http.Handler
reqLogArgs.statusCode = http.StatusText(statusCodeInt)
reqLogArgs.took = took

if errType == respClientError { // nolint:staticcheck
reqLogArgs.clientError = ww.ErrorMessage
if reqLogArgs.clientError == "" {
reqLogArgs.clientError = "unknown error"
}
} else if errType == respServerError {
reqLogArgs.serverError = ww.ErrorMessage
if reqLogArgs.serverError == "" {
reqLogArgs.serverError = "unknown error"
}
switch errType {
case respClientError:
reqLogArgs.clientError = processErrorMessage(ww.ErrorMessage)
case respServerError:
reqLogArgs.serverError = processErrorMessage(ww.ErrorMessage)
}

logRequestAfterHandler(r.Context(), l, reqLogArgs)
Expand Down
Loading