Skip to content

fix: mel cm trigger OnLevelEnd on non-flag finish - #383

Open
pektezol wants to merge 3 commits into
p2sr:masterfrom
pektezol:fix/mel-cm-levelend
Open

pektezol wants to merge 3 commits into
p2sr:masterfrom
pektezol:fix/mel-cm-levelend

Conversation

@pektezol

@pektezol pektezol commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Mel CM doesn't handle runs ending on elevator properly. Replace changelevel event with OnLevelEnd, which SAR already triggers the CM flag for. With this, elevaator behaviour should match base game, and the demo should contain ScoreboardTempUpdate user message so LPHUB can grab portal count and time taken.

Mel CM doesn't handle runs ending on elevator properly. Replace TransitionFromMap() event with OnLevelEnd, which SAR already triggers the CM flag for. With this, elevaator behaviour should match base game, and the demo should contain ScoreboardTempUpdate user message so LPHUB can grab portal count and time taken.
@pektezol
pektezol marked this pull request as draft October 26, 2026 16:55
@pektezol

Copy link
Copy Markdown
Member Author

Manual testing in progress.

@pektezol

Copy link
Copy Markdown
Member Author

CM screen is confirmed to appear after elevator/non-flag finish. Demo includes ScoreboardTempUpdate packet with correct num_portals and time_taken. Thanks to SuperAiderton for testing.

image

@pektezol
pektezol marked this pull request as ready for review October 27, 2026 05:24

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant