Repository navigation
feat: define stack paths, environments, and exclusions - #328
Merged
Merged
Conversation
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Service registration would preserve a second source for target membership after stack configuration is consolidated. Signed-off-by: panicboat <panicboat@gmail.com>
Rule keys derived from stack paths allow teams and products to define exclusion boundaries without extending the schema. Signed-off-by: panicboat <panicboat@gmail.com>
All consumers depend on the same schema and exclusion matcher, so the replacement needs an ordered implementation plan without compatibility adapters. Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Readers need the configuration and component behavior in their chosen language. Keep explanations, headings, and references within each locale while sharing executable examples. Signed-off-by: panicboat <panicboat@gmail.com>
ConsolePresenter requires String#colorize even when instantiated under GITHUB_ACTIONS. Load the existing dependency regardless of presenter selection and cover rendering in a fresh CI process so local preload state cannot hide missing dependencies. Signed-off-by: panicboat <panicboat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
同じ stack のパスと環境属性を一か所で管理し、プロダクト間の共有と独立を同じ構成で表現する。サービス・環境・任意 placeholder の条件で個々の対象を除外できるようにする。
各言語の読者が設定と動作をその言語だけで理解できるよう、英語版と日本語版に同じ範囲の説明を持たせる。
ConsolePresenterは実行環境にかかわらずString#colorizeに依存するため、既存のcolorize依存を常に読み込む。CI の presenter 選択と依存の読み込みを混同すると、CI 環境で console 出力を検証したときに失敗する。Changes
stacksに統合し、各定義にname、id、paths、environmentsまたはattributes、excludeを配置。colorizeを環境によらず読み込み、別 Ruby プロセスのGITHUB_ACTIONS=true条件で console 表示を検証する回帰テストを追加。Design
Validation
VERIFIED:
action-scriptsで Ruby 4.0.7 / Bundler 2.6.7 を使用。依存・lockfile・バージョン指定ファイルの変更なし。340 examples, 0 failures。NoMethodError: colorizeで失敗し、依存の読み込み後に成功。親プロセスで読み込まれた gem の状態に依存しない。Configuration is valid、stack・環境数のサマリー。WorkflowConfigで検証。Action の使用例14件で必須入力、CLI 26箇所で実装済みコマンドと shell 構文を確認。python3 /tmp/check_readme_locales.py、/opt/homebrew/bin/rbenv exec ruby /tmp/check_readme_examples.rbはともに exit 0、全項目PASS。CI Environment Verification
両コマンドは exit 0。
Review
別 context の reviewer に全体をレビュー依頼し、重要な2件を実 filesystem の RED→GREEN テストで修正した。読み取り権限エラー時は部分 matrix を成功として返さず、許可されたドット始まりの環境・任意 placeholder を列挙する。service のドット始まりは探索時に対象外にする。保留した minor 指摘はない。
Rulings
.claude/worktrees/stack-configurationを使用し、tracked.gitignoreの追加変更を避けた。誤った checkout の編集を避けるため workdir を固定。Dir.childrenとFile.statによるパス要素ごとの列挙を採用。実権限エラーの伝播とドット要素の一致を保証し、prefix と既知値で探索を制限。大きなディレクトリでは列挙コストが増える。allの予約を維持。文法外のサービス名には別途ラベル契約の変更が必要。config-manager validateの不正設定時の終了コードを維持。このコマンドだけで CI を停止したい場合の終了コード変更は対象外。SOURCE_REPO_PATHから enclosing checkout を探索する既存方針を維持。誤設定時に別 checkout を探索する可能性が残る。