Repository navigation
fix: support checking out action ref in composite actions - #330
Merged
Merged
Conversation
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
In composite actions (label-dispatcher and label-resolver),
actions/checkoutfor deploy-actions didn't specify aref, causing it to always checkout the latest commit from the default branch (main). This broke caller workflows whenever breaking changes were merged tomainbefore or without releasing, and bypassed commit/tag pinning on caller workflows.This PR:
deploy-actions-refinput (defaulting to empty).${{ inputs.deploy-actions-ref || github.action_ref }}to the deploy-actions checkout step, ensuring composite actions checkout the ref/tag/SHA pinned by the caller by default, while allowing explicit override.deploy-actions-repositoryinput tolabel-resolverfor consistency withlabel-dispatcher.