Repository navigation
feat!: discover stack environments and expand attributes - #334
Merged
Merged
Conversation
Resolve attribute-free environment targets from repository paths and derive attribute values from the same captures used for target identity.
BREAKING CHANGE: stacks without attributes or environments require {environment} in every path. Environment-shared stacks must explicitly specify attributes, including an empty map.
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
環境属性が不要な stack でも、ディレクトリにある環境ごとに対象を生成できるようにするためです。環境共通の対象は
attributesの指定で識別し、省略の意味を一意にします。repository や IAM role の属性値をパスの抽出値で組み立て、サービス・チーム・環境名の重複記載を減らします。Behavior
environmentsを指定した stack は定義環境とその属性を使います。attributesを指定した stack は環境共通で、ディレクトリごとに一度だけenvironment: nullを生成します。属性が不要な場合もattributes: {}が必要です。{environment}から環境名を取得します。すべてのパスに{environment}が必要で、追加属性は空です。Verification
VERIFIED:
bundle exec rspec --format progress: 370 examples, 0 failuresGITHUB_ACTIONS=true GITHUB_TOKEN=test_token GITHUB_REPOSITORY=test/repo bundle exec rspec --format progress: 370 examples, 0 failuresbundle exec ruby config-manager/bin/config-manager validate: Configuration is valid; stacks: 3 configured; environments: 3 configuredgit diff --check: exit 0gh pr checks 334: RSpec、設定検証、PR タイトル、SHA 固定、DCO はすべて pass。GitHub 上の RSpec も 370 examples, 0 failures。Placeholder Coverage
REASONED(実装の読解による未対応箇所の確認):
excludeの条件値はリテラルの完全一致です。抽出値を含む条件文字列の展開は未対応です。stack、stack_id、working_directoryを参照する形式は未対応です。