Repository navigation
fix: match changed files only under a stack path directory - #337
Merged
Merged
Conversation
A stack path such as `dystopia/{service}` resolves to a directory, but
the dispatcher also matched a changed file whose own path equals the
resolved path. `dystopia/README.md` was captured as the service
`README.md` and produced a `deploy:README.md` label that the resolver
can never turn into a deployment target, because the resolver only
walks real directories.
Require at least one path segment after the pattern so that only files
located under the resolved directory are detected. The match stays
path-based so that deleted files keep being detected.
Claude-Session: https://claude.ai/code/session_01W3CmNyPA4mB5efonYJRPij
Signed-off-by: panicboat <panicboat@gmail.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
stack のパス（例:
dystopia/{service}）はディレクトリを指しますが、label-dispatcher は変更ファイル自身のパスが解決後のパスと等しい場合も一致として扱っていました。panicboat/monorepo#1451 ではdystopia/README.mdがサービスREADME.mdとして抽出され、deploy:README.mdラベルが付与されました。label-resolver は実ディレクトリだけを対象にするため、このラベルは deployment target になりません。Behavior
PatternMatcher.extract_prefixは、パターンの後ろに 1 セグメント以上続くパスだけに一致します。パターンと完全に一致するパス、および末尾が/で終わるパスはnilを返します。{service}の位置にあるファイル（dystopia/README.md）と、{environment}の位置にあるファイル（dystopia/web/kubernetes/overlays/README.md）は変更検出の対象外です。Verification
VERIFIED:
expected: ["api"] got: ["README.md", "api"]ほか）bundle exec rspec: 373 examples, 0 failuresworkflow-config.yamlと #1451 の変更ファイル一覧をDetectChangedServicesに入力:["deploy:frontend", "deploy:monolith"]（修正前はdeploy:README.mdを含む）🤖 Generated with Claude Code
https://claude.ai/code/session_01W3CmNyPA4mB5efonYJRPij