Repository navigation
Conversation
Stage records and optional ratings require one contract across the interface, BFF and monolith. Account-weighted aggregation prevents multiple profiles from multiplying an author's influence, while retaining old memos avoids inventing event dates during migration. Signed-off-by: panicboat <panicboat@gmail.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Contributor
Kustomize DiffService: No changes |
Contributor
Kustomize DiffService: No changes |
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
… interface Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
…tings Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
Signed-off-by: panicboat <panicboat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
カルテを一回限りの評価から、予約・接客・その後の出来事を追記する記録へ変更します。UIは参照HTMLの構成に合わせ、既存のバックエンド連携を維持します。性能を比較できるよう、他のUI変更PRとは独立したブランチです。
Status
実装中です。既存データを残すマイグレーション、所有権・完了状態の制約、アカウントごとの平均評価、詳細・出来事・状態変更のgRPC/BFF接続とカルテ画面まで反映しています。自分の状態別一覧、ゲストの平均評価、任意評価と出来事入力、共通サイドパネルを接続済みです。投稿・メッセージ・プロフィール等のパネルと他画面、実ブラウザの確認を続けています。
Validation
VERIFIED: フロントエンド全体714 tests passed、tsc成功。カルテ関連72 tests passed。Docker PostgreSQLでバックエンド全体816 examplesを実行し、1件は既存Review repositoryの作成・更新に異なる時計を使う日時テストで失敗。同条件のmainでも再現しており、対象外の修正は行っていません。全体815 examples / 0 failuresを確認した区切りもありますが、日時の失敗は環境依存で残っています。
検証環境は専用ColimaとDocker DBです。Ruby 4とBundler 2の警告を避けるため、依存lockを維持してBundler 4で検証。ESLintはlock内のTypeScript JS APIをpreloadし、型検査には実際のTypeScript 7を使用。変更範囲のlintは新規errorなし。mainと同じAppShellのeffect error、HomeのuseMemo warning 2件、全体proto lintの対象外11件を確認しています。カルテproto lintは成功しています。
Refs #1517
Refs #1519