feat(esapi): add missing TPM2 commands in dictionary_attack_functions - #673
Open
hyperfinitism wants to merge 1 commit into
Open
hyperfinitism wants to merge 1 commit into
hyperfinitism wants to merge 1 commit into
Conversation
Added the following Esys wrappers with integration tests: - dictionary_attack_lock_reset (ESAPI spec 11.3.86) - dictionary_attack_parameters (11.3.87) Signed-off-by: Takuma IMAMURA <209989118+hyperfinitism@users.noreply.github.com>
hyperfinitism
force-pushed
the
feature/da-lockout
branch
from
September 19, 2026 10:53
5cbf02f to
01799aa
Compare
Superhepper
approved these changes
Sep 19, 2026
wiktor-k
approved these changes
Sep 22, 2026
wiktor-k
left a comment
wiktor-k
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 👍
The read_dictionary_attack_parameters helper could be improved a bit to return struct with named fields because the tuple is barely readable but since this is a small, contained place I don't have any issues with leaving this as-is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the following missing Esys wrappers with integration tests:
dictionary_attack_lock_reset(ESAPI spec 11.3.86)dictionary_attack_parameters(11.3.87)Migrated from #625.