ci: require a changeset and a conventional-commit PR title - #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
PR Checksworkflow so a bump like #30 can no longer land without a changeset (which left the release un-cut).Why: the release flow is driven entirely by changesets — a PR that changes the package without one silently skips versioning and npm publish.
How: a new
pr-checks.ymlwith two jobs:amannn/action-semantic-pull-requestvalidates the PR title against conventional-commit shape (runs oneditedtoo, so fixing the title re-checks without a push), andchangeset status --since=origin/mainfails when a published package changed without a changeset while still passing docs/CI-only PRs. The changesets bot's ownchangeset-release/mainPR is exempt, since it consumes changesets rather than carrying one.