editor: add presentation.findInCatalog opt-out for the action menu - #756
Merged
Conversation
Panel-placed plugin kinds (e.g. pets) have no catalog entry to find; let a definition drop the Search action while keeping move/duplicate/delete. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FB5xnSoozJZ1jXCFgbLSDG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an optional
presentation.findInCatalog?: booleantoNodeDefinitionand gates the floating action menu's "Find in catalog" button on it (default unchanged). Panel-placed plugin kinds — like the Bloblins pets plugin, whose creatures are hatched from its own panel and have no catalog entry — can setfindInCatalog: falseto drop the Search action while keeping move/duplicate/delete.How to test
bun dev, open a project, select a built-in node (wall, item) — the action menu still shows the Find in catalog button as before.presentation: { findInCatalog: false, ... }(e.g.@wass08/plugin-bloblins) and select one of its nodes — the Search button is absent; Move/Duplicate/Delete remain.cd packages/core && bun run check-types— the new field is additive and optional.Screenshots / screen recording
N/A — removes one conditional button for opted-out kinds; no visual change for built-ins.
Checklist
bun devbun checkto verify)mainbranchNote
Low Risk
Small, additive registry flag and a single UI gate; default behavior is unchanged when the field is omitted.
Overview
Adds optional
presentation.findInCatalogon node definitions so kinds can hide the floating action menu’s Find in catalog action without affecting other buttons.The menu still passes
onFindonly whencanFindNodeis true and the selected kind’s registry entry does not setfindInCatalog: false. Omitted ortruekeeps today’s behavior for built-ins; plugin kinds placed only from a panel (e.g. Bloblins pets) can opt out while move, duplicate, and delete stay unchanged.Reviewed by Cursor Bugbot for commit 468002d. Bugbot is set up for automated code reviews on this repo. Configure here.