Skip to content

editor: add presentation.findInCatalog opt-out for the action menu - #756

Merged
wass08 merged 1 commit into
mainfrom
feat/find-in-catalog-optout
Sep 2, 2026
Merged

editor: add presentation.findInCatalog opt-out for the action menu#756
wass08 merged 1 commit into
mainfrom
feat/find-in-catalog-optout

Conversation

@wass08

@wass08 wass08 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Adds an optional presentation.findInCatalog?: boolean to NodeDefinition and gates the floating action menu's "Find in catalog" button on it (default unchanged). Panel-placed plugin kinds — like the Bloblins pets plugin, whose creatures are hatched from its own panel and have no catalog entry — can set findInCatalog: false to drop the Search action while keeping move/duplicate/delete.

How to test

  1. bun dev, open a project, select a built-in node (wall, item) — the action menu still shows the Find in catalog button as before.
  2. Load a plugin whose definition sets presentation: { findInCatalog: false, ... } (e.g. @wass08/plugin-bloblins) and select one of its nodes — the Search button is absent; Move/Duplicate/Delete remain.
  3. cd packages/core && bun run check-types — the new field is additive and optional.

Screenshots / screen recording

N/A — removes one conditional button for opted-out kinds; no visual change for built-ins.

Checklist

  • I've tested this locally with bun dev
  • My code follows the existing code style (run bun check to verify)
  • I've updated relevant documentation (if applicable)
  • This PR targets the main branch

Note

Low Risk
Small, additive registry flag and a single UI gate; default behavior is unchanged when the field is omitted.

Overview
Adds optional presentation.findInCatalog on node definitions so kinds can hide the floating action menu’s Find in catalog action without affecting other buttons.

The menu still passes onFind only when canFindNode is true and the selected kind’s registry entry does not set findInCatalog: false. Omitted or true keeps today’s behavior for built-ins; plugin kinds placed only from a panel (e.g. Bloblins pets) can opt out while move, duplicate, and delete stay unchanged.

Reviewed by Cursor Bugbot for commit 468002d. Bugbot is set up for automated code reviews on this repo. Configure here.

Panel-placed plugin kinds (e.g. pets) have no catalog entry to find; let a
definition drop the Search action while keeping move/duplicate/delete.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FB5xnSoozJZ1jXCFgbLSDG
@wass08
wass08 merged commit 8a6c43f into main Sep 2, 2026
4 checks passed
@wass08
wass08 deleted the feat/find-in-catalog-optout branch September 2, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant