feat!: remove HTML rendering support - #149
Merged
Merged
Conversation
BREAKING CHANGE: NitroText no longer accepts the `renderer` prop or exports the `Renderer` type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rendererprop andRenderertypeBreaking change
NitroTextno longer acceptsrenderer="html"orrenderer="plaintext", and the package no longer exportsRenderer.Verification
bun run test -- --runInBand --no-watchmanbun run buildbunx nitrogen --logLevel=debugregenerated the same substantive native diff./gradlew :app:assembleDebug --no-daemon --stacktracenpm pack --dry-run --jsoncontains no removed renderer/parser filesgit diff --checkLocal environment notes
mainor this branch becauseeslint.config.mjsimports the undeclaredeslint-plugin-nitro-modulespackage.fmt/format-inl.hconsteval code before NitroText compiles. The repository CI uses Xcode 16.4.