Repository navigation
Conversation
Every PR that touches ft8af/** now gets an installable debug APK, uploaded as an artifact and linked from a sticky PR comment. The PR build in android.yml is an unsigned release APK, which phones refuse to install. Also adds a PR description template (APK link, manual test checklist, what changed, risks, automated tests) and branch-name and PR rules in AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #924 +/- ##
=========================================
Coverage 41.51% 41.51%
Complexity 252 252
=========================================
Files 280 280
Lines 33993 33993
Branches 4034 4034
=========================================
Hits 14112 14112
Misses 19592 19592
Partials 289 289
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Debug APKDownload FT8AF-pr924-f6dee78-debug.zip (built from f6dee78, run) Unzip it and install the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debug APK
This PR changes the workflow file, so it runs the new job itself. Use the "Debug APK" comment CI posts below. It's built from current
dev, since this PR doesn't touch app code.Manual test checklist
FT8AF-pr<N>-<sha>-debug.zip..apkon a phone. If the Play Store build is installed, uninstall it first (different signing key). The app should launch, and Settings should show a-devversion.What changed
.github/workflows/pr-debug-apk.yml(new). On PRs todev/staging/mainthat touchft8af/**, it runsassembleDebug, uploadsFT8AF-pr<N>-<sha>-debug.apkas an artifact (kept 30 days), and posts or updates one sticky PR comment with the download link. The existing PR build inandroid.ymlmakes an unsigned release APK, which Android refuses to install, so it was no use for testing on a phone. Fork PRs get the APK on the run page but no comment, because their token is read-only..github/pull_request_template.md(new). Sections: Debug APK, a 3-6 step manual test checklist, what changed, risks, and what was tested automatically.AGENTS.md. New "Branch names" and "Pull requests" sections: agents never merge, fill in the template, wait for the APK comment, CI must be green, request a Copilot review, and label Discord-sourced PRsfrom-discord.android.ymlis unchanged. Unit tests (testDebugUnitTest+ coverage) and the release build already run on every Android PR there, behindandroid-gate.Risks
Low. The change only adds files and has no app code or release-lane changes.
Debug APK for manual testinga required check. It's path-filtered at the trigger, so on non-Android PRs it never reports and would block merging.android-gatestays the required check.applicationIdas the Play build but a different signing key. Testers need to uninstall the Play build first, which wipes app data. If that gets in the way, a follow-up could addapplicationIdSuffix ".debug"so both can be installed side by side (check Maps and other package-bound keys first).Tested automatically
.github/scripts/check-agents-md.shpasses locally.android.ymldoesn't run here because nothing underft8af/**changed.🤖 Generated with Claude Code