Repository navigation
fix(submissions): decode iPhone HEIC photos instead of failing the response - #145
Merged
patriksimms merged 3 commits intoOct 15, 2026
Conversation
…sponse The contributor form accepts HEIC, but the prebuilt sharp binaries cannot decode HEVC-coded pixels. Every iPhone photo therefore failed the submission with a generic image error. Contributors then retried, reloaded and clicked the error again and again. The image pipeline now decodes HEVC HEIC with libheif's WebAssembly build (heic-decode). It hands the pixels on as a lossless PNG that keeps the photo's own ICC profile, so the master keeps its colour space. AVIF and other formats still go straight to sharp. Image failures that end in the generic 422 are now logged and sent to error tracking, so they are no longer invisible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 0e71ffef-e903-4230-b773-d9dc0123d940
|
Important Review skippedThis PR was authored by a bot without an assigned CodeRabbit review seat. Ask an organization administrator to assign a seat to the bot. See the seat-assignment guide. After the seat is assigned, request a review again. ⚙️ Run configuration
You can disable this status message by setting the
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…hunk The libheif WebAssembly bundle now loads only when a HEIC photo arrives. The checksum uses crc32 with a starting value instead of a joined copy. The PNG header offset now has a name, and the comment states only why the code exists. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Generated-By: PostHog Desktop Task-Id: 0e71ffef-e903-4230-b773-d9dc0123d940
Select the designated primary image before decoding multi-image HEIC uploads, keeping its dimensions and ICC metadata aligned with the pixels. Preserve alpha for transparent photos and release decoder handles on both success and failure. Add focused primary-photo, transparency, and HEIF rotation fixtures. Use a HEIC upload in the production-image journey and document codec limitations. Validation: bun run verify passes, including 468 unit tests, 48 integration tests, 46 browser tests and the production build. The primary-photo test failed against the original PR implementation. Refs #118, #145. AI-Assisted: true AI-Agent: codex AI-Model: openai/gpt-6.1-sol
Owner
|
@coderabbitai review |
|
patriksimms
marked this pull request as ready for review
October 15, 2026 12:46
Owner
|
@CodeRabbit help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
Owner
|
@CodeRabbit review |
|
patriksimms
deleted the
posthog-self-driving/fixshared-page-repeated-rage-clicks-on-ad698c
branch
October 15, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Contributors could not submit iPhone HEIC photos because Sharp's prebuilt binaries lack an HEVC decoder. The resulting 422 also hid the cause from logs and error tracking.
Origin
signals-scout-generalChanges
HEVC-coded HEIC photos now decode through a lazily loaded WebAssembly codec before entering the existing Sharp pipeline. Multi-image files use their designated primary photo, with its dimensions and ICC profile. Transparent photos keep their alpha channel in PNG masters, and HEIF rotation is applied before producing the master and sRGB WebP preview. Image-processing failures are logged and reported.
The 200 MP guard remains in place before pixel decoding. README documents codec installation and limitations. No deployment configuration changes are required. Decoding runs on the main thread and produces 8-bit pixels; large batches can still reach the existing submission timeout.
Validation
bun run verifypasses locally: formatting, lint, typecheck, 468 unit tests, 48 integration tests, 46 browser tests with 2 intentional skips, build, and deployment checks.bun run smoke:productionpasses locally using the shipped Bun 1.3.9 image. The initial attempt inherited development Clerk keys and failed before upload; the rerun used the smoke fixture defaults.11e4ce2: both push and pull-request runs ofverifyandproduction-imageare green.Review status
Independent full review of
92e3b61...11e4ce2found no blocking or non-blocking findings. No unresolved review threads remain.The PR remains draft because both configured review bots are unavailable for this commit:
No deployment configuration changes are required. Completing the configured bot gate needs the account owners to restore Macroscope credits and assign a CodeRabbit seat, then rerun the reviews.
Refs #118.
Original implementation by Claude Code. Review improvements delivered by GPT-6.1-Sol through the Codex harness in T3 Code.