Skip to content

feat(ssr-cache): add Redis-based server-side rendering cache with tes… - #2

Open
pcg-kk wants to merge 127 commits into
mainfrom
redis
Open

pcg-kk wants to merge 127 commits into
mainfrom
redis

Conversation

@pcg-kk

@pcg-kk pcg-kk commented Oct 11, 2026

Copy link
Copy Markdown
Owner

…ts and configurations

References

Add references/links to any related issues or PRs. These may include:

  • Fixes #issue-number (if this fixes an issue ticket)
  • Requires DSpace/DSpace#pr-number (if a REST API PR is required to test this)

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

ConfusionOrb221 and others added 29 commits May 27, 2026 13:02
Also used margin bottom on the EditItemPageComponent tabs to allign the spacing with the comcol pages
Orejime requires a non-empty apps list, so initializing with apps=[] when
enableCookieConsentPopup is false logged a console error. Return early
instead and guard showSettings when no instance exists.

Fixes DSpace#6009
The Bootstrap grid is composed of 12 columns, but we are not using
the entire grid, which could lead to unexpected stacking depending
on the viewport size. This also adjusts the columns to be consist-
ent with the sizing use by the search results page (3+9).
The Bootstrap grid is composed of 12 columns, but we are not using
the entire grid, which could lead to unexpected stacking depending
on the viewport size. This also adjusts the columns to be consist-
ent with the sizing use by the search results page (3+9).
Set max-width of item-page-field components to 75 characters. This
is in line with some best practices regarding readability, though
may need to be adjusted in the future.

See the following recommendations:
  - 50 to 75 characters: https://baymard.com/blog/line-length-readability
  - 60 to 80 characters: https://pimpmytype.com/line-length-line-height/
  - 50 to 75 characters: https://www.uxpin.com/studio/blog/optimal-line-length-for-readability/
  - 50 to 75 characters: https://medium.com/@wblekhoa/talk-aboutthe-optimal-length-of-text-in-ux-ui-525e689f0b71
  - Less than 80 characters: https://www.w3.org/WAI/WCAG21/Understanding/visual-presentation.html
An anonymous item render fires ~15 per-feature authorization checks, about ten
of which ask about admin/edit/login-only capabilities an unauthenticated
visitor can never hold. AuthorizationDataService.isAuthorized now answers
false locally, without a REST call, for those features when no one is logged
in, and waits for isAuthenticationLoaded() before deciding so authenticated
users are never transiently treated as anonymous.

Measured on a local DSpace 11 stack with OpenTelemetry tracing: an anonymous
item render drops from 42 to 31 backend calls (15 to 5 authorization checks)
and single-core SSR render throughput rises ~45%.

Refs DSpace#6256, DSpace#3161

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…is visible

Anonymous users (or any viewer without access to a draft in-progress
version) could tell that an item had a draft version under review,
because the Version History section was rendered as soon as the
version history contained at least one visible version — which is
always true for the item currently being viewed. This leaked the
existence of hidden version activity, contradicting the REST contract
which says this must not be discoverable.

Change the two visibility guards in item-versions.component.html to
require more than one visible version (via versionsDTO.totalElements)
before rendering the title, alert and table, instead of more than
zero. The totalElements count already reflects only the versions the
current user is authorized to see, so the section now stays hidden
whenever there is nothing meaningful to compare against.

Co-Authored-By: Claude <noreply@anthropic.com>
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.2.0 to 4.3.0.
- [Commits](https://github.com/kornelski/http-cache-semantics/commits)

---
updated-dependencies:
- dependency-name: http-cache-semantics
  dependency-version: 4.3.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hono](https://github.com/honojs/hono) from 4.13.5 to 4.13.13.
- [Release notes](https://github.com/honojs/hono/releases)
- [Commits](honojs/hono@v4.13.5...v4.13.13)

---
updated-dependencies:
- dependency-name: hono
  dependency-version: 4.13.13
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
The spec relied on the real AuthorizationDataService being created for
FileDownloadLinkComponent. Now that the service depends on AuthService,
that construction fails with a missing AuthRequestService provider,
which the test runner also reports as a circular dependency. Provide
the existing stub, as other component specs do.

Assisted-by: Claude Code [claude-opus-5-5]
bram-atmire and others added 30 commits October 31, 2026 10:13
Remove the per-object feature ID memo. The request cache already
deduplicates the identical unfiltered searches, and the memo's own
expiry did not follow request-cache invalidation. Move pagination into
findAllAuthorizationsForObject and handle every failure with a single
fallback to the individual feature check.

Resolving the feature links no longer waits for a successful response:
a failed feature link now errors, triggering that fallback instead of
leaving the check pending.

Assisted-by: Claude Code [claude-opus-5-5]
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.10 to 2.0.11.
- [Release notes](https://github.com/chimurai/http-proxy-middleware/releases)
- [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.11/CHANGELOG.md)
- [Commits](chimurai/http-proxy-middleware@v2.0.10...v2.0.11)

---
updated-dependencies:
- dependency-name: http-proxy-middleware
  dependency-version: 2.0.11
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 7.4.6 to 7.4.7.
- [Release notes](https://github.com/cypress-io/github-action/releases)
- [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md)
- [Commits](cypress-io/github-action@v7.4.6...v7.4.7)

---
updated-dependencies:
- dependency-name: cypress-io/github-action
  dependency-version: 7.4.7
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…cypress-io/github-action-7.4.7

build(deps): bump cypress-io/github-action from 7.4.6 to 7.4.7
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.16.1 to 1.16.2.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](follow-redirects/follow-redirects@v1.16.1...v1.16.2)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-version: 1.16.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [systeminformation](https://github.com/sebhildebrandt/systeminformation) from 5.33.1 to 5.33.19.
- [Release notes](https://github.com/sebhildebrandt/systeminformation/releases)
- [Changelog](https://github.com/sebhildebrandt/systeminformation/blob/master/CHANGELOG.md)
- [Commits](sebhildebrandt/systeminformation@v5.33.1...v5.33.19)

---
updated-dependencies:
- dependency-name: systeminformation
  dependency-version: 5.33.19
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…steminformation-5.33.19

build(deps): bump systeminformation from 5.33.1 to 5.33.19
…llow-redirects-1.16.2

build(deps): bump follow-redirects from 1.16.1 to 1.16.2
…tp-proxy-middleware-2.0.11

build(deps): bump http-proxy-middleware from 2.0.10 to 2.0.11
…nse-csv

Adjust CC License section to take i18n keys from csv instead of values from API
The inner condition gating the version table/pagination was accidentally
changed to totalElements > 1 alongside the outer visibility check. This
hid the table and its actions (create/delete/edit summary) in Edit Item >
Version History whenever only one version remained. Restore it to check
versionDTOs.length > 0 so the single version row and its actions are shown
again, while the outer totalElements > 1 || displayWhenEmpty check still
prevents anonymous users from seeing the table when a draft version is
hidden.

Co-Authored-By: Claude <noreply@anthropic.com>
…button-for-edit-dso-pages_contribute-main

Hide duplicate back/cancel button on the collection mapper page
…rsion

Co-Authored-By: Claude <noreply@anthropic.com>
…me-when-disabled

fix(cookies): skip Orejime init when consent popup is disabled
Fixing spacing between submit button and accessiblity card
…oading-for-Theme-Translations

Allow Runtime i18n Loading for Theme Translations (no build-time merge for i18n files)
…th-a-draft-version-shows-a-versio

Hide Version History table when only one version is visible
…uction

Batch anonymous authorization checks per object
Disable SSR and SSR caching for authenticated HTTP GET requests
DSpace#6269)

* Includes a redirect to the 404 page when accessing community, collection, and item pages without an ID.

* Fix for the last commit

* Extending handling to new components and code adjustments

* Aligning with best practices

* Aligning with best practices

* Update browse-by component

* Update browse-by component
…after-metadata-value

Fix DSpace#6254: UI spacing regression on ds-generic-item-page-field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.