Repository navigation
Conversation
…pdown menu increase in size
Also used margin bottom on the EditItemPageComponent tabs to allign the spacing with the comcol pages
Orejime requires a non-empty apps list, so initializing with apps=[] when enableCookieConsentPopup is false logged a console error. Return early instead and guard showSettings when no instance exists. Fixes DSpace#6009
…18n-Loading-for-Theme-Translations
…file-page.component
The Bootstrap grid is composed of 12 columns, but we are not using the entire grid, which could lead to unexpected stacking depending on the viewport size. This also adjusts the columns to be consist- ent with the sizing use by the search results page (3+9).
The Bootstrap grid is composed of 12 columns, but we are not using the entire grid, which could lead to unexpected stacking depending on the viewport size. This also adjusts the columns to be consist- ent with the sizing use by the search results page (3+9).
Set max-width of item-page-field components to 75 characters. This is in line with some best practices regarding readability, though may need to be adjusted in the future. See the following recommendations: - 50 to 75 characters: https://baymard.com/blog/line-length-readability - 60 to 80 characters: https://pimpmytype.com/line-length-line-height/ - 50 to 75 characters: https://www.uxpin.com/studio/blog/optimal-line-length-for-readability/ - 50 to 75 characters: https://medium.com/@wblekhoa/talk-aboutthe-optimal-length-of-text-in-ux-ui-525e689f0b71 - Less than 80 characters: https://www.w3.org/WAI/WCAG21/Understanding/visual-presentation.html
An anonymous item render fires ~15 per-feature authorization checks, about ten of which ask about admin/edit/login-only capabilities an unauthenticated visitor can never hold. AuthorizationDataService.isAuthorized now answers false locally, without a REST call, for those features when no one is logged in, and waits for isAuthenticationLoaded() before deciding so authenticated users are never transiently treated as anonymous. Measured on a local DSpace 11 stack with OpenTelemetry tracing: an anonymous item render drops from 42 to 31 backend calls (15 to 5 authorization checks) and single-core SSR render throughput rises ~45%. Refs DSpace#6256, DSpace#3161 Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…18n-Loading-for-Theme-Translations
…is visible Anonymous users (or any viewer without access to a draft in-progress version) could tell that an item had a draft version under review, because the Version History section was rendered as soon as the version history contained at least one visible version — which is always true for the item currently being viewed. This leaked the existence of hidden version activity, contradicting the REST contract which says this must not be discoverable. Change the two visibility guards in item-versions.component.html to require more than one visible version (via versionsDTO.totalElements) before rendering the title, alert and table, instead of more than zero. The totalElements count already reflects only the versions the current user is authorized to see, so the section now stays hidden whenever there is nothing meaningful to compare against. Co-Authored-By: Claude <noreply@anthropic.com>
Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.2.0 to 4.3.0. - [Commits](https://github.com/kornelski/http-cache-semantics/commits) --- updated-dependencies: - dependency-name: http-cache-semantics dependency-version: 4.3.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hono](https://github.com/honojs/hono) from 4.13.5 to 4.13.13. - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v4.13.5...v4.13.13) --- updated-dependencies: - dependency-name: hono dependency-version: 4.13.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
The spec relied on the real AuthorizationDataService being created for FileDownloadLinkComponent. Now that the service depends on AuthService, that construction fails with a missing AuthRequestService provider, which the test runner also reports as a circular dependency. Provide the existing stub, as other component specs do. Assisted-by: Claude Code [claude-opus-5-5]
Remove the per-object feature ID memo. The request cache already deduplicates the identical unfiltered searches, and the memo's own expiry did not follow request-cache invalidation. Move pagination into findAllAuthorizationsForObject and handle every failure with a single fallback to the individual feature check. Resolving the feature links no longer waits for a successful response: a failed feature link now errors, triggering that fallback instead of leaving the check pending. Assisted-by: Claude Code [claude-opus-5-5]
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.10 to 2.0.11. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.11/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.10...v2.0.11) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-version: 2.0.11 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [cypress-io/github-action](https://github.com/cypress-io/github-action) from 7.4.6 to 7.4.7. - [Release notes](https://github.com/cypress-io/github-action/releases) - [Changelog](https://github.com/cypress-io/github-action/blob/master/CHANGELOG.md) - [Commits](cypress-io/github-action@v7.4.6...v7.4.7) --- updated-dependencies: - dependency-name: cypress-io/github-action dependency-version: 7.4.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…cypress-io/github-action-7.4.7 build(deps): bump cypress-io/github-action from 7.4.6 to 7.4.7
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.16.1 to 1.16.2. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.16.1...v1.16.2) --- updated-dependencies: - dependency-name: follow-redirects dependency-version: 1.16.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [systeminformation](https://github.com/sebhildebrandt/systeminformation) from 5.33.1 to 5.33.19. - [Release notes](https://github.com/sebhildebrandt/systeminformation/releases) - [Changelog](https://github.com/sebhildebrandt/systeminformation/blob/master/CHANGELOG.md) - [Commits](sebhildebrandt/systeminformation@v5.33.1...v5.33.19) --- updated-dependencies: - dependency-name: systeminformation dependency-version: 5.33.19 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…steminformation-5.33.19 build(deps): bump systeminformation from 5.33.1 to 5.33.19
…llow-redirects-1.16.2 build(deps): bump follow-redirects from 1.16.1 to 1.16.2
…tp-proxy-middleware-2.0.11 build(deps): bump http-proxy-middleware from 2.0.10 to 2.0.11
…nse-csv Adjust CC License section to take i18n keys from csv instead of values from API
The inner condition gating the version table/pagination was accidentally changed to totalElements > 1 alongside the outer visibility check. This hid the table and its actions (create/delete/edit summary) in Edit Item > Version History whenever only one version remained. Restore it to check versionDTOs.length > 0 so the single version row and its actions are shown again, while the outer totalElements > 1 || displayWhenEmpty check still prevents anonymous users from seeing the table when a draft version is hidden. Co-Authored-By: Claude <noreply@anthropic.com>
…button-for-edit-dso-pages_contribute-main Hide duplicate back/cancel button on the collection mapper page
…rsion Co-Authored-By: Claude <noreply@anthropic.com>
…me-when-disabled fix(cookies): skip Orejime init when consent popup is disabled
Fixing spacing between submit button and accessiblity card
…oading-for-Theme-Translations Allow Runtime i18n Loading for Theme Translations (no build-time merge for i18n files)
…th-a-draft-version-shows-a-versio Hide Version History table when only one version is visible
…uction Batch anonymous authorization checks per object
Disable SSR and SSR caching for authenticated HTTP GET requests
DSpace#6269) * Includes a redirect to the 404 page when accessing community, collection, and item pages without an ID. * Fix for the last commit * Extending handling to new components and code adjustments * Aligning with best practices * Aligning with best practices * Update browse-by component * Update browse-by component
…after-metadata-value Fix DSpace#6254: UI spacing regression on ds-generic-item-page-field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ts and configurations
References
Add references/links to any related issues or PRs. These may include:
Description
Short summary of changes (1-2 sentences).
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
List of changes in this PR:
Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.