Repository navigation
chore: back-merge main into dev before Sprint 159 release - #3073
Merged
Merged
Conversation
During the pwa-sunset window the desktop hero showed only two store web links — the one desktop download surface without the QR path every other surface (home, setup, guest CTAs) follows, and a store web page is a dead end for someone sitting at a laptop. Add the Download now primary that opens ScanToDownloadModal, keep the store pair. Flag-off renders are untouched: every changed line lives inside the migrationOn && isDesktop branch.
…the modal Kush's review: three CTAs on the hero is noise; the modal already carries the store links under the QR.
prod still carried the placeholder apps.apple.com/app/peanut in STORE_URL and REVIEW_URL — flag-on would send every iOS user to a wrong listing. ports the real id6786373552 URLs already on dev (no back-merge debt).
fix: real iOS App Store URLs before pwa-sunset flag-on (hotfix)
…esktop-qr fix(landing): TASK-20600 desktop hero Download now opens the scan-to-download QR
…0908-054749 content: publish latest to production (src/content → peanut-content@c49e663)
…333) Mexico is tagged region 'latam' for the region picker, but its bank rail (SPEI) is a Bridge rail. Every bank-flow unlock CTA derived the KYC intent from that picker region and sent LATAM + targetCountry=MX; the BE rejects MX for the Manteca path and the UI collapsed the typed rejection into the 'contact support' dead-end. 8 approved Mexico users have no SPEI rail. Add getBankRegionIntent (MX -> NA, else the region intent) and route all six bank-flow call sites through it — add-money bank, withdraw bank, the countries list and the bank claim — so the fix lives in one place instead of the one page the report named (regression of hotfix #2163 coverage). The region picker keeps getRegionIntent: it works off the clicked region, not a country.
Reuse the existing 'Bridge serves this country' predicate instead of a fifth hard-coded MX literal — the rule is 'latam picker country whose bank rail is Bridge', and the predicate is already the withdraw page's routing guard.
…ver the saved-account claim path Review fixes (/code-review medium on #3036): - getBankRegionIntent now reads RAIL_COUNTRY_TO_REGION_PATH — the table the pending-rail badges already use — instead of a Bridge-membership predicate that would flip AR/BR/CO to NA the day BRA/COL land in the Bridge alpha3 map. One source of truth for 'which region tile does this rail belong to'. - BankFlowManager: only the country list set selectedCountry, so a saved account (CLABE) reached the unlock CTA with a rest-of-world intent. Set it from the account — the account is the destination. - withdraw page: one country lookup for intent and target country. - page test asserts intent + crossRegion only; the country arg is dropped by useSumsubKycFlow for non-Manteca countries, so it must not be pinned.
… picked country Third-reviewer finding on #3036: setSelectedCountry(getCountryFromAccount(account) ?? null) overwrote a country the user already chose when the saved account's metadata has no resolvable country (empty countryCode/countryName — a known prod state), turning an EU uplift into a rest-of-world dead end. Guard the write, and add the first BankFlowManager test: saved MX CLABE → selectedCountry = Mexico; unresolvable account → no write; unlock CTA → NA intent.
…tent-na fix(kyc): route Mexico bank enrollment through the NA intent (TASK-22333)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jjramirezn
marked this pull request as ready for review
September 9, 2026 13:21
jjramirezn
requested review from
0xkkonrad,
Hugo0,
abalinda,
innolope-dev and
kushagrasarathe
as code owners
September 9, 2026 13:21
Contributor
Code-analysis diffPainscore total: 8913.88 → 8914.96 (+1.08) 🆕 New findings (13)
✅ Resolved (13)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
jjramirezn
enabled auto-merge
September 9, 2026 13:28
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
Clean exact-head review. The back-merge preserves the production desktop QR download behavior and staging's Mexico enrollment flow; no actionable correctness, security, adversarial, or maintainability defect was found.
Checked clean
- Verified the detached worktree at the supplied head, trusted author and dev base metadata, merge base, effective three-file diff, and both-parent conflict resolution.
- Checked the desktop migration CTA against the production hotfix and the existing Button, Hero, ScanToDownloadModal, DownloadQR, device-detection, close-state, and LANDING_HERO attribution contracts.
- Checked the Mexico needs-enrollment regression against the preserved verify-step flow and NA intent assertion; the detached worktree has no installed Jest binary, so the focused local rerun was unavailable.
- Confirmed src/content is a gitlink-only update from f5990317950a71a7cdea8f15d0a8fda20d13213f to the production parent's c49e663855da992ab54b1fa488fecb00abaf3cd4, with no content-file edits in this PR.
- Checked exact-head automation: Deploy-Preview, Vercel, analyze, and bot-approval passed; no test-suite check was reported for this head.
- Ran security and slop passes over the effective diff; it adds no authorization, credential, sensitive-data, money, workflow-secret, or process-execution surface.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: 853396235c7c · Context: repo · Took 9m
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the production desktop download QR behavior into staging before the Sprint 159 release. Resolve main-to-dev conflicts while preserving the newer staging bank-flow modules and residence-aware Mexico routing.
Tracking: https://app.notion.com/p/3d68381175798149887ff4085840c232
The saved-account tests retain CLABE inference and unknown-account country protection. Keep staging's real App Store/review URLs. Restore the Mexico enrollment regression against the new verify step. The src/content pointer matches production c49e663, avoiding a release rollback to staging's August 27 mirror; no content files are edited.
Validation: targeted bank-flow tests pass (79 tests); full local suite passes (560 suites, 6,916 tests; 5 skipped), typecheck and Prettier pass. Local production build passes (1,106 static pages; local Sentry upload reported 401 warnings but build exited zero). CI must pass before merge. Visual reference: production hotfix #3024 contains desktop flag-on, QR modal, and flag-off screenshots. This back-merge carries that same behavior; no fresh local screenshot is claimed. TASK-20600 and TASK-22333 are retained by this sync.