fix: TASK-22452 receipt mechanical fixes - #3171
kushagrasarathe wants to merge 1 commit into
Conversation
…link (TASK-22452) the white wordmark was invisible on the white receipt; five hand-rolled value+copy rows bypass DataRow's overflow protection and allowCopy; the PDF link was a raw-anchor LinkButton clone with no hit area; the go-home CTA nested a Button inside a Link. LinkButton grows external/download plain-anchor rendering so the PDF route is never viewport-prefetched.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/chip review |
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings in the receipt component migration or its link and copy behavior changes.
Checked clean
- Verified the exact head SHA, supplied base SHA, merge base, trusted author, and eight-file diff scope.
- Checked DataRow copy migrations for displayed-value and copied-value parity across counterparty, transaction hash, bank account, transfer ID, and public receipt reference rows.
- Checked LinkButton plain-anchor behavior and DownloadReceiptPdfLink web and Capacitor paths, including new-tab isolation and URL encoding.
- Checked ReceiptUnavailable navigation semantics, public receipt branding, keyboard behavior, and print-only copy-icon suppression against the design-system contract.
- Exact-head substantive CI did not run for this stacked base; git diff --check passed, while focused local Jest execution was unavailable because the detached worktree has no current dependency installation.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: c8fe41208c44 · Context: repo, design · Took 12m (queued 7m)
This branch was successfully deployed
1 participant
Summary
PR-C (mechanical half) of the TASK-22452 audit:
allowCopy+copyValue(reference row nowmiddleEllipsisAccount, last 4 visible); the shared copy glyph gainsshrink-0 print:hidden.download+ renders external/download hrefs as plain anchors (kills next/link viewport-prefetch of the PDF route; DOM-identical for existing external consumers). Capacitor intercept preserved; its test passes unchanged.<Link><Button/></Link>→ Button + router.push; legacyprimary-soft→stroke.Decision-blocked receipt items (CTA hierarchy, hasReceiptPage widening) are NOT here.
Task
TASK-22452 (audit section 2, PR-C mechanical)
Risks / breaking changes
Flagged, not changed
app/apppage<a><Button>nesting — migration surface, out of scope.min-w-0 break-words) rather than single-line-ellipsizing — per-row ellipsis done at value construction; a DataRow-level rule needs a ruling.QA
typecheck, prettier, TransactionDetails+0_Bruddle suites (42 suites, 438 pass; receipt-download-pdf test unchanged), new LinkButton download test, ds-lint ratchet green.
Screenshots: receipt visual deltas (black wordmark, ellipsized reference) — will attach with the stack's evidence pass.
Stacked on #3161 — retarget to
devafter it merges.