fix(qr-pay): handle missing merchant destinations - #3218
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code-analysis diffPainscore total: 7997.19 → 7997.42 (+0.23) 🆕 New findings (3)
✅ Resolved (3)
|
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings. The new destination-not-found code is preserved by the QR init transport, classified as deterministic, mapped to existing localized merchant-unavailable copy, and covered by the exact-head unit suite.
Checked clean
- Exact head and trusted PR metadata matched the supplied repository, author, base ref, and SHAs.
- Reviewed the three-file merge-base diff across wire-code recognition, retry behavior, scan outcome classification, and localized failure copy.
- Verified the paired peanut-api-ts PR emits PAYMENT_DESTINATION_NOT_FOUND as a typed 422 code and the UI transport preserves response codes.
- Exact-head unit, typecheck, eslint, format, screen-tests, native-export, and analyze checks succeeded; visual capture jobs were still in progress when checked.
- Targeted local Jest execution was unavailable because the detached read-only worktree has no installed node_modules; exact-head CI unit coverage succeeded.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: 3e445813a7a4 · Context: repo, sibling-repo · Took 7m
🖼 Visual diff — 2 screens moved3 of 96 shots changed · 93 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
Pair the API
PAYMENT_DESTINATION_NOT_FOUNDresponse with the QR client.Pairs with peanut-api-ts PR #1595.