test(withdraw): cover blank-country GB and CLABE accounts - #3223
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code-analysis diffPainscore total: 7997.19 → 7997.19 (0) |
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings in the added blank-country saved-account regression coverage.
Checked clean
- Exact head and merge base matched the supplied SHAs; trusted author and dev base matched the supplied metadata.
- Blank-country GB and CLABE fixtures match reachable saved-account shapes and exercise both country-resolution helpers.
- The resolved countries feed the existing outbound minimum contract: GBP 3 and MXN 50, including FX conversion and rate gating.
- Unknown non-bank account types remain unresolved, so the tests do not broaden fallback behavior.
- Exact-head CI unit, typecheck, ESLint, and format gates passed; diff whitespace validation passed.
- Local scoped Jest could not run because the detached worktree has no installed Jest binary; exact-head CI unit coverage passed.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.
Exact head: ea85ef917eaf · Context: repo, product · Took 13m
Summary
Closes TASK-22395.
Validation