Skip to content

test(withdraw): cover blank-country GB and CLABE accounts - #3223

Merged
innolope-dev merged 1 commit into
devfrom
innolope/sprint-160-pr-followups-ui
Sep 17, 2026
Merged

innolope-dev merged 1 commit into
devfrom
innolope/sprint-160-pr-followups-ui

Conversation

@innolope-dev

Copy link
Copy Markdown
Collaborator

Summary

  • cover saved GB and CLABE accounts whose country metadata is blank in both country-resolution helpers
  • confirm unknown non-bank account types remain unresolved
  • pin the resulting GBP/MXN withdrawal minimum path through getCountryFromAccount

Closes TASK-22395.

Validation

  • 91 scoped tests passed
  • scoped Prettier passed
  • scoped ESLint passed
  • full typecheck is blocked in the isolated worktree by absent repository-managed binary/generated assets; no touched-file type errors remained

@vercel

vercel Bot commented Sep 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Sep 17, 2026 4:38am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 17, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 53241e66-0c42-4b0a-a937-037675a4d441

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@innolope-dev innolope-dev self-assigned this Sep 17, 2026
@notion-workspace

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 7997.19 → 7997.19 (0)
Findings: 0 net (+0 new, -0 resolved)

@innolope-dev
innolope-dev marked this pull request as ready for review September 17, 2026 04:40
@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 7620 ran, 0 failed, 0 skipped, 2.4m

📊 Coverage (unit)

metric %
statements 78.7%
branches 65.8%
functions 72.8%
lines 79.8%
⏱ 10 slowest test cases
time test
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › a refused idempotency key tells the user to scan again, not to contact support
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_VOLUME_NEAR_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_RECENT_REFUND fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › User KYC not approved fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › routes the KYC rejection on its wire code, and does not retry it
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_SOURCE_OVER_MONTHLY_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_USER_NOT_PROVISIONED fails fast with copy that names the real cause
3.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Scan that recovers on the retry lands on the payment screen, not an error
3.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Going offline blames the connection, and reconnecting clears it for the recovered scan
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@chip-peanut-bot chip-peanut-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chip review — no blocking findings — this is not an approval

No findings in the added blank-country saved-account regression coverage.

Checked clean

  • Exact head and merge base matched the supplied SHAs; trusted author and dev base matched the supplied metadata.
  • Blank-country GB and CLABE fixtures match reachable saved-account shapes and exercise both country-resolution helpers.
  • The resolved countries feed the existing outbound minimum contract: GBP 3 and MXN 50, including FX conversion and rate gating.
  • Unknown non-bank account types remain unresolved, so the tests do not broaden fallback behavior.
  • Exact-head CI unit, typecheck, ESLint, and format gates passed; diff whitespace validation passed.
  • Local scoped Jest could not run because the detached worktree has no installed Jest binary; exact-head CI unit coverage passed.

Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.

Third opinion by claude-opus: 0 finding(s), marked with the model name. It answers only product truth, missing tests and the cross-repo contract, so treat its findings as advice.

Exact head: ea85ef917eaf · Context: repo, product · Took 13m

@innolope-dev
innolope-dev merged commit de8290f into dev Sep 17, 2026
35 of 36 checks passed

This branch was successfully deployed

1 active deployment
Preview — ea85ef91 Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant