Repository navigation
TASK-23054: "virtual account" in support subjects and the load error - #3454
Merged
Merged
Conversation
The app names these accounts "virtual account" everywhere since #3446. The prefilled support subjects and the load-error fallback still said "deposit account", so the user and support saw two names for one thing.
Hugo0
requested review from
0xkkonrad,
abalinda,
innolope-dev,
jjramirezn and
kushagrasarathe
as code owners
September 25, 2026 07:09
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Code-analysis diffPainscore total: 8864.35 → 8864.51 (+0.16) |
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings.
Checked clean
- Exact head and merge base match the supplied SHAs; reviewed both changed files and their support/error call paths.
- The changes alter only support subject copy and a fallback API error message; no control flow, data contract, or security behavior changes.
- At review time, format, typecheck, eslint, and other completed checks passed; several CI jobs remained in progress.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion: did not run — claude-api_error. This review is one reviewer short.
Exact head: 298b66ec34e4 · Context: repo, product · Took 3m
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app calls these accounts "virtual account" (one term, since #3446). Five strings still said "deposit account":
DepositAccountsFlowContainer: "Another virtual account", "Couldn't open virtual account", "Revoked virtual account details", "Extra check needed for virtual account".services/deposit-accounts.ts: "Could not load virtual accounts".Code identifiers and the /dev pages keep their names. Found by the mono#178 content refresh.
Local: Jest for deposit-accounts and services: 46 suites pass; prettier clean.