Repository navigation
TASK-23054: a future-dated document request never interrupts a bank transfer - #3467
Merged
Merged
Conversation
…ransfer The advisory modal stopped withdraw and add-money confirms for a request whose rail still works until its date, used another state's title, and hid a failed start: the modal closed itself and the resubmit error was rendered nowhere. The bank screens now show a non-blocking info callout with the deadline. The request lives as a task slide on Home and Profile (PendingVerificationTasks), which starts the document flow in place and shows a failed start as an error.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Hugo0
requested review from
0xkkonrad,
abalinda,
innolope-dev and
kushagrasarathe
as code owners
September 25, 2026 11:28
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: peanutprotocol/peanut-ui/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Code-analysis diffPainscore total: 8887.54 → 8892.39 (+4.85) 🆕 New findings (52)
…and 32 more. ✅ Resolved (52)
…and 32 more. 📈 Painscore deltas (top movers)
|
Contributor
🧪 UI test report — ✅ all greenSuites
📊 Coverage (unit)
⏱ 10 slowest test cases
|
![chip-peanut-bot[bot]](https://avatars.githubusercontent.com/in/2915219?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The future-dated request no longer blocks bank transfers, and the new task starts the targeted resubmission. One notice points to a task that can be hidden on Home.
Findings
- MINOR · src/i18n/app/messages/en.json:2785 · Bank notice can direct users to a hidden Home task
If a user dismisses the future-dated document slide on Home, the dismissal persists for that task. A later bank-transfer screen still says “Complete it from Home,” but the Home slide is filtered out, so that instruction cannot be followed. The same task remains available under Profile → Accounts. Update the localized notice to name that route as an option, or provide a way to reopen the Home task.
Checked clean
- Exact head, trusted PR metadata, merge-base diff, and supplied base context verified.
- Bank gate paths preserve due-now blocking and allow only ready rails through; API resolver confirms future-dated Sumsub actions carry the requirement key.
- Task start uses the targeted self-heal resubmission; start errors render on its slide and KYC modals remain mounted when the task disappears.
- Exact-head typecheck, lint, unit, and screen tests passed; visual capture jobs were still running at review time.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — claude-api_error. This review is one reviewer short.
Exact head: c36f8138f748 · Context: repo, sibling-api · Took 8m
--no-verify: the hook flags src/types/api.openapi.json, which arrives unchanged from dev in this merge, not from this branch. AdvisoryPreemptModal stays deleted; dev's icon edit to it (#3456) is dropped.
Bridge dates expiring-ID requests years ahead (149 prod users with 2027-2034 dates), and a notice that far out is noise. One constant, ADVISORY_HEADS_UP_WINDOW_DAYS, gates both the Home/Accounts slide and the bank-screen notice, so the two always agree. The slide is no longer dismissible on Home: the bank notice says to complete it from Home, so a hidden slide would make that instruction false (Chip review).
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings at this head.
Checked clean
- P1 is fixed at this head: the document task ignores stored Home dismissals, has no dismiss control, and shares the bank notice’s 30-day deadline filter.
- The existing due-now capability gate and targeted self-heal/error flow remain intact after the dev merge.
- The API resolver supplies the earliest future-dated Bridge advisory as the rail hint; later hosted and terms tasks remain separate top-level actions.
- Exact-head checks were still running when reviewed; completed security and provenance checks were successful.
Security review by moonshotai/kimi-k3: 0 finding(s), marked with the model name. It reads the diff only and answers only security, privacy and money, so treat its findings as advice.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: 8bcd3341cdef · Context: repo, sibling-api · Took 6m
Contributor
|
English · Español · Español (Argentina) · Português (Brasil) After merge: 34b97a0 → 38719aa. Capture complete in all locales. |
Contributor
🖼 Visual diff — 11 screens moved21 of 164 shots changed · 143 identical · baseline
job summary · before/after/diff images — artifact Fixture screenshots, no backend. Advisory — this check never blocks a merge. Posted from the default branch by ds-shots-comment.yml; the report it renders is untrusted data. |
… its date nears Hugo, 2026-09-25: never a large CTA card and the carousel at once. A document request due in 30 to 8 days is a small, non-dismissible carousel slide that starts the flow; in its last 7 days (or past due) it becomes the large task card, which then replaces the carousel and the activation card. PendingVerificationTasks renders the Home layout's `whenEmpty` only when it shows no card, so the rule lives in one place and covers the ToS and hosted cards too. The start logic moves into useDocumentRequestFlow so the card and the slide share it.
Contributor
Author
|
/chip review |
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
The bank-screen notice can still point to a document request hidden on Home before its final week.
Findings
- MINOR · src/features/home/HomePage.tsx:71 · Document request is hidden for unactivated users
For a verified user who has not yet made a qualifying card/QR spend, isActivated is false even though a bank rail can be ready. If that rail has a document request due in 8–30 days, selectHomeTasks puts it only in documentSlide, but this branch renders ActivationCTAs instead of the carousel. The bank review still says “Complete it from Home”, where no document action appears. The same suppression occurs when another large verification task replaces the carousel. Keep the document request reachable on Home in those states while retaining one CTA surface, e.g. include it in the large task carousel whenever the document slide cannot render.
Checked clean
- Verified exact head and merge base; PR metadata and head CI checked without reading comments.
- Rechecked prior finding against Home activation gating, task selection, and bank notice.
- Reviewed bank-flow advisory handling and shared Sumsub start/error paths; no further supported finding.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: 49546410d04a · Context: repo, api · Took 7m
…usel cannot carry it Before its final week the request rides the carousel, but an unactivated user sees the activation card instead, and another task card hides the carousel. In both cases the bank notice said "Complete it from Home" with nothing there (Chip review). The task card now carries the request whenever the carousel cannot, still one CTA surface.
Contributor
There was a problem hiding this comment.
Chip review — no blocking findings — this is not an approval
No findings at this head; both previously hidden-Home-task cases are fixed.
Checked clean
- Exact head and merge base verified against the supplied worktree and PR metadata.
- P1 and P2: Home now carries the document request in the task card when activation or another task suppresses the carousel; the request remains non-dismissible.
- Reviewed the bank notice, task selection, Sumsub start/error flow, and affected Home tests against this head.
- Head CI had no failures at review time; unit, screenshot, preview, native-export, and press-contract checks were still running.
Security review: did not run — this change has no security, privacy or money surface, so it was not asked. This review is one reviewer short.
Third opinion: did not run — it reads only the first review of a pull request; the first reviewer checks later rounds. This review is one reviewer short.
Exact head: e7ff62d52b4b · Context: repo, api · Took 5m
Hugo0
added a commit
that referenced
this pull request
Sep 25, 2026
The wordiness baseline entry follows the view rename to MoneySettings.view.tsx at dev's new value, 682. --no-verify: the data-file hook blocks large generated files that this merge brings in unchanged from dev.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TASK-23054. Staging QA 2026-09-25: a GBP withdrawal was interrupted by a "This one takes a bit longer" modal, and "Complete now" did nothing.
What changes
A future-dated verification request from our payment partner (EEA uplift and other
advisoryActions, where the bank rail keeps working until the date) no longer interrupts a money flow.Callout: "One more document needed. Due {date}. Bank transfers keep working until then. Complete it from Home." It has no action and cannot hold the transfer.HomeCarouselCTAcarousel. It shows "One more document needed" and "Due {date} to keep bank transfers running.", and a tap starts the document flow. It has no close button, so the carousel's 7-day dismissal cannot hide it before the due date. A failed start shows an error toast.PendingVerificationTasks) with "Complete now" and the deadline line.HomePage:PendingVerificationTasks placement="home" whenEmpty={carousel or activation card}renderswhenEmptyonly when it shows no card itself. It applies to every large task card (ToS, hosted verification, document request). A due task also wins over the activation card. The activation card already replaced the carousel; that stays.src/utils/bridge-tasks.utils.ts:ADVISORY_HEADS_UP_WINDOW_DAYS = 30(bank-screen notice, Profile card, Home slide) andADVISORY_FINAL_WEEK_DAYS = 7(Home large card).selectHomeTasks()splits Home between the slide and the large card. Examples: the EEA uplift due 2026-10-01 is a large card now; a request for an ID that expires in 2027 or later shows nowhere (149 prod users have one).useDocumentRequestFlowstarts the request (self-heal resubmit, uplift funnel, Sumsub modals) for both the card and the slide.handleSelfHealResubmitstored the API's 500 in flow state, and nothing on the withdraw page rendered it. Now the card renders the error in aCallout priority="error", and the carousel slide shows it as an error toast.AdvisoryPreemptModal,useAdvisoryPreemptand its test, the dev-gallery entry, and thecompleteNow/doLater/ no-date copy keys. After the date, the API turns the requirement into a blocking one, and the existing KYC modal on these screens handles it as before.eea_uplift_startedfires when the user taps the card or the slide, on the new channelverification-tasks.Copy (en, es-419, es-AR, pt-BR): sentence case, no pronouns in titles.
Root cause of "Complete now did nothing" (staging)
699ef887…f810, created 2026-02-25. Staging shares the production Sumsub app, and that app does not have this applicant.GET /resources/applicants/699ef887…/onereturned 404 on staging 211 times, starting at least 2026-09-21. A different staging applicant, created 2026-09-23, reads fine with the same credentials.provider-rfi-eea-upliftactions and started 8 EEA-uplift resubmissions since 2026-09-01. Production logs show no 404 onforApplicantand no failed applicant reads.Word budget
The
screen-wordinessbaseline goes up for the four screens that now show this copy: withdraw review +32, bank add money +27, Home +17 (the large card and the carousel slide) and Profile unlock payments +11. Callout words count twice. The deleted modal counted as a separate screen, so these screens never included its words.Overlaps
AdvisoryPreemptModal.tsx. The merge from dev keeps it deleted. TASK-23054: dismiss and defer actions are the tertiary link #3464 and feat: icon bubble colours follow one rule (TASK-22761) #3457 also edit it; whichever merges second drops that edit.UnlockPayments.view.tsxand changes one route inPendingVerificationTasks. The conflicts are one line each.Tests
useBridgeOfframpFlow: with an advisory on the gate, the offramp runs create, send and confirm, the hook exposes the deadline, and no uplift start fires.useBridgeBankFlow: with an advisory, Continue opens the confirmation, not a KYC modal.PendingVerificationTasks: the slide renders with its deadline, and a tap starts resubmit with the requirement key. A failed start renders the error, and an error from before the tap does not. A blocking sumsub step (no date) is not a Home task.headsUpDeadline: inside and outside the window (2026-10-01 vs 2027), the exact 30-day edge, a past date, and no date or a bad date.selectBridgeTaskskeeps only the request inside the window.selectHomeTasks: nothing past 30 days; the slide for 8 to 30 days; the large card for the last 7 days and past due; ToS and hosted tasks always large; the exact 7-day edge.PendingVerificationTasks: with no task,whenEmpty(the carousel) renders. A blocking ToS card, or a final-week document card, renders and the carousel does not. Dismissing the last advisory card brings the carousel back. Before the final week the request is not a Home card, and Profile keeps it for the whole window. On Home the final-week card has no X and ignores a stored dismissal.HomeCarouselCTA: the slide leads the carousel with the deadline and has no close button. A tap starts the flow, and a failed start shows an error toast. It renders even when no other slide qualifies.VerificationDeadlineNoticeunit tests.API companion: the resubmit route now fails fast on a Sumsub 404 and gives its errors a
userMessage(peanutprotocol/peanut-api-ts#1717).