Skip to content

TASK-23054 gate the drawer shadow-clip spec in press-contract - #3489

Closed
Hugo0 wants to merge 1 commit into
devfrom
ci/TASK-23054-gate-drawer-shadow-clip
Closed

Hugo0 wants to merge 1 commit into
devfrom
ci/TASK-23054-gate-drawer-shadow-clip

Conversation

@Hugo0

@Hugo0 Hugo0 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Runs e2e/flows/drawer-shadow-clip.spec.ts (from #3487) in the required press-contract job, so a clipped CTA shadow fails ci-success. It also raises the job timeout from 20 to 25 min. The spec took 1.4 min in CI on #3487.

This changes a workflow, so the backdoor guard stays red until someone other than the author reads .github/workflows/tests.yml.

Merge order: after #3487. Until then the spec is not on dev and press-contract fails here. Update this branch from dev once #3487 merges, then CI goes green.

A clipped CTA shadow shows only in real layout and has shipped twice. The
spec from ui#3487 runs in advisory ds-shots today; running it in the required
press-contract job makes a clipped shadow fail ci-success.
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
peanut-wallet Ready Ready Preview Sep 25, 2026 6:08pm UTC

Request Review

@notion-workspace

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR changes CI workflows or the backdoor scan itself

The scan in tests.yml runs this PR's own workflow, so a change here could switch it off. This check stays red until the change is merged. Someone other than the author must read these files before anyone runs the branch:

  • .github/workflows/tests.yml

@github-actions

Copy link
Copy Markdown
Contributor

Code-analysis diff

Painscore total: 8966.82 → 8966.82 (0)
Findings: 0 net (+0 new, -0 resolved)

@github-actions

Copy link
Copy Markdown
Contributor

🧪 UI test report — ✅ all green

Suites

  • ✅ unit: 10276 ran, 0 failed, 0 skipped, 3.9m

📊 Coverage (unit)

metric %
statements 82.5%
branches 72.4%
functions 77.4%
lines 83.8%
⏱ 10 slowest test cases
time test
🐢 9.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Network failure keeps loading while retries remain, then shows the generic error
4.2s src/components/Card/share-asset/__tests__/shareAssetLayout.test.ts › never places two stickers in heavy overlap (broad seed sweep)
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_SOURCE_OVER_MONTHLY_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › User KYC not approved fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_RECENT_REFUND fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › routes the KYC rejection on its wire code, and does not retry it
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_USER_NOT_PROVISIONED fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › MANTECA_MERCHANT_VOLUME_NEAR_CAP fails fast with copy that names the real cause
4.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › a refused idempotency key tells the user to scan again, not to contact support
3.0s src/app/(mobile-ui)/qr-pay/__tests__/qr-pay-states.test.tsx › Going offline blames the connection, and reconnecting clears it for the recovered scan
📍 Inline annotations are in the **Unit test report** check above. Coverage artifact: `coverage-unit`. Generated by `.github/workflows/tests.yml`.

@Hugo0

Hugo0 commented Sep 25, 2026

Copy link
Copy Markdown
Contributor Author

Folded back into #3487 (Hugo: land the fix and its gate together).

@Hugo0 Hugo0 closed this Sep 25, 2026
@Hugo0
Hugo0 deleted the ci/TASK-23054-gate-drawer-shadow-clip branch September 25, 2026 18:14

This branch was successfully deployed

1 active deployment
Preview — 3c115ea0 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant