Skip to content

Added Add, Edit, & Delet Validations for EmbeddedData Editable table #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tumms2021389 merged 1 commit into from
Aug 27, 2026
Merged

Added Add, Edit, & Delet Validations for EmbeddedData Editable table #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...ages/react-sdk-components/src/components/template/SimpleTable/SimpleTable/SimpleTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ interface SimpleTableProps extends PConnProps {
ruleClass?: string;
authorContext?: string;
name?: string;
allowActions?: any;
editMode?: string;
}

export default function SimpleTable(props: SimpleTableProps) {
Expand All @@ -44,7 +46,9 @@ export default function SimpleTable(props: SimpleTableProps) {
type,
ruleClass,
authorContext,
name
name,
allowActions,
editMode
} = props;

let { contextClass } = props;
Expand Down Expand Up @@ -117,7 +121,18 @@ export default function SimpleTable(props: SimpleTableProps) {
return <ListView {...listViewProps} />;
}
const simpleTableManualProps: any = { ...props, contextClass };
if (allowTableEdit === false) {

const checkIfAllowActionsOrRowEditingExist = newflagobject => {
return (newflagobject && Object.keys(newflagobject).length > 0) || getPConnect().getComponentConfig().allowRowEdit;
};

if (checkIfAllowActionsOrRowEditingExist(allowActions) && editMode) {
simpleTableManualProps.hideAddRow = allowActions?.allowAdd === false;
simpleTableManualProps.hideDeleteRow = allowActions?.allowDelete === false;
simpleTableManualProps.hideEditRow = allowActions?.allowEdit === false;
simpleTableManualProps.allowRowEdit = getPConnect().getComponentConfig().allowRowEdit;
simpleTableManualProps.allowEdit = getPConnect().getComponentConfig().allowActions?.allowEdit;
} else if (allowTableEdit === false) {
simpleTableManualProps.hideAddRow = true;
simpleTableManualProps.hideDeleteRow = true;
simpleTableManualProps.disableDragDrop = true;
Expand Down
24 changes: 16 additions & 8 deletions ...dk-components/src/components/template/SimpleTable/SimpleTableManual/SimpleTableManual.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ interface SimpleTableManualProps extends PConnProps {
required?: boolean;
targetClassLabel?: string;
uniqueField?: string;
hideEditRow?: boolean;
}

const useStyles = makeStyles((/* theme */) => ({
Expand Down Expand Up @@ -117,6 +118,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
contextClass,
hideAddRow,
hideDeleteRow,
hideEditRow,
propertyLabel,
fieldMetadata,
editMode,
Expand Down Expand Up @@ -196,6 +198,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
const allowEditingInModal =
(editMode ? editMode === 'modal' : addAndEditRowsWithin === 'modal') && !(renderMode === 'ReadOnly' || isDisplayModeEnabled);
const showDeleteButton = editableMode && !hideDeleteRow;
const showEditButton = allowEditingInModal && !hideEditRow;
const { allowRowDelete: allowRowDeleteConfig } = pConn.getComponentConfig?.() ?? {};

const isDeleteAllowedForRow = (index: number): boolean => {
Expand Down Expand Up @@ -235,7 +238,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa

useEffect(() => {
buildElementsForTable();
if (readOnlyMode || allowEditingInModal) {
if (readOnlyMode || allowEditingInModal || hideEditRow) {
generateRowsData();
}
}, [referenceList]);
Expand Down Expand Up @@ -434,7 +437,10 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
configFields.forEach(item => {
// removing label field from config to hide title in the table cell
if (!item.config.hide) {
item = { ...item, config: { ...item.config, label: '', displayMode: readOnlyMode || allowEditingInModal ? 'DISPLAY_ONLY' : undefined } };
item = {
...item,
config: { ...item.config, label: '', displayMode: readOnlyMode || allowEditingInModal || hideEditRow ? 'DISPLAY_ONLY' : undefined }
};
const referenceListData = getReferenceList(pConn);
const isDatapage = referenceListData.startsWith('D_');
const pageReferenceValue = isDatapage
Expand Down Expand Up @@ -685,7 +691,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
}
return (
<TableCell key={`head-${displayedColumns[index]}`} className={classes.tableCell}>
{(readOnlyMode || allowEditingInModal) && field.cellRenderer !== 'DeleteIcon' ? (
{(readOnlyMode || allowEditingInModal || hideEditRow) && field.cellRenderer !== 'DeleteIcon' ? (
<div style={{ display: 'flex' }}>
<TableSortLabel
style={{ width: '75%' }}
Expand Down Expand Up @@ -718,6 +724,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
<TableBody>
{editableMode &&
!allowEditingInModal &&
!hideEditRow &&
elements.map((row: any, index) => {
const theKey = `row-${index}`;
return (
Expand Down Expand Up @@ -748,7 +755,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
</TableRow>
);
})}
{(readOnlyMode || allowEditingInModal) &&
{(readOnlyMode || allowEditingInModal || hideEditRow) &&
rowData &&
rowData.length > 0 &&
stableSort(rowData, getComparator(order, orderBy)).map((row: any, displayIndex) => {
Expand All @@ -763,7 +770,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
</TableCell>
);
})}
{showDeleteButton && (
{(showDeleteButton || showEditButton) && (
<TableCell key='DeleteIcon' className={classes.tableCell}>
<div>
<MoreIcon
Expand All @@ -774,7 +781,7 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
}}
/>
<Menu id='table-edit-menu' anchorEl={editAnchorEl} keepMounted open={Boolean(editAnchorEl)} onClose={_menuClose}>
<MenuItem onClick={() => editRecord()}>Edit</MenuItem>
{showEditButton && <MenuItem onClick={() => editRecord()}>Edit</MenuItem>}
{isDeleteAllowedForRow(originalIndex) && <MenuItem onClick={() => deleteRecord()}>Delete</MenuItem>}
</Menu>
</div>
Expand All @@ -786,8 +793,9 @@ export default function SimpleTableManual(props: PropsWithChildren<SimpleTableMa
</TableBody>
</Table>
{((readOnlyMode && (!rowData || rowData?.length === 0)) ||
(editableMode && (!referenceList || referenceList?.length === 0)) ||
(allowEditingInModal && (!rowData || rowData?.length === 0))) && (
(editableMode && !hideEditRow && (!referenceList || referenceList?.length === 0)) ||
(allowEditingInModal && (!rowData || rowData?.length === 0)) ||
(hideEditRow && (!rowData || rowData?.length === 0))) && (
<div className='no-records' id='no-records'>
{getGenericFieldsLocalizedValue('COSMOSFIELDS.lists', 'No records found.')}
</div>
Expand Down
Loading