Skip to content

feat(windows): add default root support - #4

Open
austinconnor wants to merge 1 commit into
perplexityai:mainfrom
austinconnor:windows/support
Open

feat(windows): add default root support#4
austinconnor wants to merge 1 commit into
perplexityai:mainfrom
austinconnor:windows/support

Conversation

@austinconnor

@austinconnor austinconnor commented May 22, 2026

Copy link
Copy Markdown

Summary

  • add Windows-aware home, AppData, Program Files, and filesystem-root handling for profile root resolution
  • add Windows baseline candidates for package-manager roots, editor extensions, MCP configs, and browser extension profiles
  • preserve native package paths on Windows so the full test suite passes from this branch alone
  • document Windows support, inventory roots, and deployment examples

Fixes #2.

Verification

  • go test ./...
  • go run ./cmd/bumblebee selftest
  • go run ./cmd/bumblebee roots --profile baseline
  • GOOS=linux GOARCH=amd64 go test -c -o NUL for every package
  • GOOS=darwin GOARCH=amd64 go test -c -o NUL for every package

@austinconnor austinconnor mentioned this pull request May 25, 2026
Open
6 tasks
Niicolaa referenced this pull request in Niicolaa/bumblebee Aug 4, 2026
@claude
feat(windows): add Windows scan-root, endpoint, build, and CI support
2fd1a47 
Adds Windows to the supported endpoint set so baseline/project scans
discover MCP configs (%APPDATA%\Claude, Continue), Chromium-family
extensions (Chrome/Edge/Brave/Chromium/Vivaldi/Arc under
%LOCALAPPDATA%), and Firefox-family profiles (%APPDATA%\Mozilla\...).
isBroadHomeRoot now recognises Windows drive roots and bare
<drive>:\Users[\<name>] homes. Endpoint UID stays empty on Windows
rather than emitting "-1" when user.Current fails. setHomeDir test
helper sets HOME/USERPROFILE/APPDATA/LOCALAPPDATA together so existing
home-based tests run on all three platforms. CI matrix gains
windows-latest and goreleaser builds windows amd64/arm64 zip archives.

Tracks perplexityai#2; implemented from scratch rather than
adopting any of the open upstream PRs (#4, perplexityai#16, perplexityai#30).
Niicolaa referenced this pull request in Niicolaa/bumblebee Aug 4, 2026
@claude
fix(windows): close gaps found by reviewing the upstream Windows PRs
6504f85 
Audited the earlier Windows work against the four upstream attempts
(#3, #4, perplexityai#16, perplexityai#30) and found five things it got wrong or missed. Two of
them would have made CI red on the windows-latest runner that the same
change added to the matrix.

CI-breaking:

  - The selftest step had no `shell: bash`. windows-latest defaults to
    PowerShell, where invoking the extensionless build output does not
    work as it does in a POSIX shell. The gofmt step already pinned
    bash; this one did not.
  - scanner_test.go asserted on literal "/proj/" and "/dup/" substrings
    of source_file, which is a native path. TestEndToEndScan could only
    have passed on Unix.

Correctness:

  - npm and pnpm derived project_path by slash-joining segments after
    an internal filepath.ToSlash, so a Windows record carried
    C:/src/app instead of C:\src\app. This is upstream issue #1
    ("Windows package records should preserve native project paths");
    PR #3 was closed with the note that it would be folded into the
    broader Windows work, and it then was not. Both now convert back
    with filepath.FromSlash, with regression tests.
  - DefaultExcludes had no Windows entries, so a deep sweep of
    %USERPROFILE% descended into AppData/Local/{Temp,Microsoft,Packages}
    and AppData/LocalLow — the Windows analogue of the macOS Library
    subtrees already excluded there.
  - systemRoots returned nil on Windows, missing machine-wide Python
    under %ProgramFiles%\PythonNN\Lib\site-packages; per-user Python
    under %LOCALAPPDATA%\Programs\Python\* was missing too.

Also corrects an over-reach in the preceding ecosystem commit: it added
~/.m2/repository and ~/.gradle/caches as baseline roots, but both are in
walk.DefaultExcludes precisely because they are high-cost dependency
caches, and opening every cached JAR on a 6-hourly profile is exactly
what that exclusion exists to prevent. Those, plus the Pub/Hex/Conan/
Swift caches (which hold no file this scanner parses), are dropped from
baseline; all remain reachable via --root or a deep sweep.

To make the retained ~/.nuget/packages root earn its walk, adds a
.nuspec parser for the global packages folder — installed-state
evidence for NuGet, the analogue of RubyGems' installed *.gemspec. The
per-version directory shape is required so an authoring .nuspec in a
source tree, whose <version> is often a $token$, is not read as an
install.
Niicolaa referenced this pull request in Niicolaa/bumblebee Aug 4, 2026
@claude
fix(windows): native project paths, AppData excludes, and CI shell
078ce4a 
Follow-up to the initial Windows support, from reviewing the earlier
upstream Windows attempts (#3, #4, perplexityai#16, perplexityai#30). Two of these would have
made CI red on the windows-latest runner the previous commit added.

CI-breaking:

  - The selftest step had no `shell: bash`. windows-latest defaults to
    PowerShell, where invoking the extensionless build output does not
    work as it does in a POSIX shell. The gofmt step already pinned
    bash; this one did not.
  - scanner_test.go asserted on literal "/proj/" and "/dup/" substrings
    of source_file, which is a native path, so TestEndToEndScan could
    only have passed on Unix. Now normalized before matching.

Correctness:

  - npm and pnpm derived project_path by slash-joining segments after an
    internal filepath.ToSlash, so a Windows record carried C:/src/app
    instead of C:\src\app. This is issue #1 ("Windows package records
    should preserve native project paths"); PR #3 was closed with the
    note that it would be folded into the broader Windows work, and it
    then was not. Both now convert back with filepath.FromSlash, with
    regression tests.
  - DefaultExcludes had no Windows entries, so a deep sweep of
    %USERPROFILE% descended into AppData/Local/{Temp,Microsoft,Packages}
    and AppData/LocalLow — the Windows analogue of the macOS Library
    subtrees already excluded there.
  - systemRoots returned nil on Windows, missing machine-wide Python
    under %ProgramFiles%\PythonNN\Lib\site-packages, and per-user Python
    under %LOCALAPPDATA%\Programs\Python\* was missing as well.
@Niicolaa Niicolaa mentioned this pull request Aug 4, 2026
Merged
Niicolaa referenced this pull request in Niicolaa/bumblebee Aug 4, 2026
@claude
feat(windows): add Windows scan-root, endpoint, build, and CI support
660b527 
Adds Windows to the supported endpoint set so baseline/project scans
discover MCP configs (%APPDATA%\Claude, Continue), Chromium-family
extensions (Chrome/Edge/Brave/Chromium/Vivaldi/Arc under
%LOCALAPPDATA%), and Firefox-family profiles (%APPDATA%\Mozilla\...).
isBroadHomeRoot now recognises Windows drive roots and bare
<drive>:\Users[\<name>] homes. Endpoint UID stays empty on Windows
rather than emitting "-1" when user.Current fails. setHomeDir test
helper sets HOME/USERPROFILE/APPDATA/LOCALAPPDATA together so existing
home-based tests run on all three platforms. CI matrix gains
windows-latest and goreleaser builds windows amd64/arm64 zip archives.

Tracks perplexityai#2; implemented from scratch rather than
adopting any of the open upstream PRs (#4, perplexityai#16, perplexityai#30).
Niicolaa referenced this pull request in Niicolaa/bumblebee Aug 4, 2026
@claude
fix(windows): native project paths, AppData excludes, and CI shell
1b2ea46 
Follow-up to the initial Windows support, from reviewing the earlier
upstream Windows attempts (#3, #4, perplexityai#16, perplexityai#30). Two of these would have
made CI red on the windows-latest runner the previous commit added.

CI-breaking:

  - The selftest step had no `shell: bash`. windows-latest defaults to
    PowerShell, where invoking the extensionless build output does not
    work as it does in a POSIX shell. The gofmt step already pinned
    bash; this one did not.
  - scanner_test.go asserted on literal "/proj/" and "/dup/" substrings
    of source_file, which is a native path, so TestEndToEndScan could
    only have passed on Unix. Now normalized before matching.

Correctness:

  - npm and pnpm derived project_path by slash-joining segments after an
    internal filepath.ToSlash, so a Windows record carried C:/src/app
    instead of C:\src\app. This is issue #1 ("Windows package records
    should preserve native project paths"); PR #3 was closed with the
    note that it would be folded into the broader Windows work, and it
    then was not. Both now convert back with filepath.FromSlash, with
    regression tests.
  - DefaultExcludes had no Windows entries, so a deep sweep of
    %USERPROFILE% descended into AppData/Local/{Temp,Microsoft,Packages}
    and AppData/LocalLow — the Windows analogue of the macOS Library
    subtrees already excluded there.
  - systemRoots returned nil on Windows, missing machine-wide Python
    under %ProgramFiles%\PythonNN\Lib\site-packages, and per-user Python
    under %LOCALAPPDATA%\Programs\Python\* was missing as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Windows default root discovery

1 participant

@austinconnor