Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
InstalledVersions::isInstalled()reads theinstalled.phpof every registered Composer loader, not only the project's. A tool that the PHP binary loads before Pest, such as Laravel Herd'sdump.pharthroughauto_prepend_file, registers its own loader, and that loader declareslaravel/framework. On such a machinepest --initwrites the Laravel stubs in a project without Laravel, and the generated suite stops withThe class or trait [Tests\TestCase] could not be found. The parallel Laravel handler and the TIA watch defaults read the same data.Pest\Support\InstalledPackagesreadsInstalledVersions::getAllRawData()and skips each installed set whose root lives inside a PHAR. It answers likeisInstalled()for everything else, including development requirements and sets withoutinstall_path. Every call site insrcnow uses it.tests/Features/Init.phpbuilds a small PHAR that declareslaravel/framework, loads it with-d auto_prepend_file, and checks that--initwrites the plain stubs.tests/Unit/Support/InstalledPackages.phpcovers the filter and checks that no other class insrcreadsInstalledVersions.tests/.snapshots/success.txtandtests/Visual/Parallel.phpcount the new tests.