Repository navigation
fix(tia): end the SFC script tag after quoted attributes that hold > - #2063
Open
benddailey wants to merge 1 commit into
Open
benddailey wants to merge 1 commit into
benddailey wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
Description:
SCRIPT_BLOCK_REended the opening<script>tag at the first>, also inside a quoted attribute. A Vue generic component (generic="T extends Record<string, unknown>") then leaked the rest of the tag into the script code, and rolldown failed the whole graph build with[PARSE_ERROR] Unterminated string.The attribute part of the regex now skips quoted values:
Group 1 is still the attribute string, so the
langdetection does not change. The three branches cannot match the same character, so the regex stays linear: a 50 kB attribute takes under 1 ms.Tests in
tests/Unit/Plugins/Tia/ViteDepsHelper.php:tiaSfcFixtures()cases:generic-attribute,generic-attribute-single-quoted, andgeneric-attribute-before-lang(langafter an attribute that holds>). The existing data-driven tests run on them.Related:
Closes #2062