Repository navigation
CI-only: fix/go-module-caller-save-race at 77be9e71 (do not merge) - #70
Merged
Merged
Conversation
Caller recovery stats and reads a Go caller file without the cache lock, then stores the result with that stat. A save of the same file clears the cached stat so the next recovery checks the bytes again. If the save landed while a recovery was reading, the recovery then wrote its stat back over the cleared one. When the save kept the size and modification time, later recoveries trusted the pre-save facts and restored stale calls until the file was saved again. Each save now bumps a per-indexer epoch under the cache lock, also for a file with no cache entry yet. Recovery reads the epoch together with the entry and stores its result through storeGoModuleSource, which keeps the facts but clears the stat when the epoch moved, on both the equal-digest and the extract path. The next recovery then verifies the bytes once. TestGoModuleSourceStoreDropsTrustAfterConcurrentSave runs a save during the read for a cached file and for a first recovery. It fails without the epoch check and passes with it.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only draft to run CI for fix/go-module-caller-save-race at 77be9e7 (drop Go caller stat trust when a save overlaps source recovery; the race zzet#953 listed under Limits). Upstream zzet#980 test layout; no fork-only commit. Do not merge.