Repository navigation
CI-only: fix/hotspots-repo-scope (zzet/gortex#1003) at 46350974 (do not merge) - #71
Merged
Merged
Conversation
A scoped analyze hotspots call loaded every hotspot in the store with GetNode and only then dropped the entries outside the session workspace or the repo allow-set. Each extra tracked repo added one point read per hotspot, so a call scoped to one repo got slower as other repos were added (269 reads per call with one repo, 516 with six, on a store with 1.9 times the nodes). In a multi-repo store, a source node's ID starts with its repo prefix and a slash. The handler now builds the set of tracked repos that cannot be visible once per call, and skips an entry without a read only when its ID has that source form and its exact prefix is in the set. Single-repo IDs, stub IDs such as <repo>::stdlib::..., unknown prefixes and the unbound path keep the existing read, and analyzeNodeVisible still decides every entry that is not skipped. Ranking, the analysis cache, totals and truncation do not change. TestHotspotsScopeSkipsInvisibleRepoReads runs memory and SQLite readers with three repos, including gortex2 and a worktree prefix, for repo, workspace, empty-workspace, threshold and novelty requests. It checks that the full response equals the base filter's and counts the reads: 71 to 25 for one repo of three, 71 to 48 for the shared workspace.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only draft to run CI for fix/hotspots-repo-scope at 4635097 (zzet#1003: skip source reads for repos outside the session's scope in hotspots). Upstream zzet#980 test layout; no fork-only commit. Do not merge.