Skip to content

perf: PG19 RI fast path for FK checks + planner join-path allocations (#20) #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexshapalov merged 3 commits into from
Nov 4, 2026
+720 −323
Merged

perf: PG19 RI fast path for FK checks + planner join-path allocations (#20) #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6757292
ri_triggers: port PostgreSQL 19's per-row RI fast path into RI_FKey_c…
hoangquocvietuet Oct 22, 2026
66ef471
planner: drop avoidable allocation/copying in the join-path hot loop
hoangquocvietuet Oct 22, 2026
c2fc00d
Merge branch 'main' into perf/issue-20
alexshapalov Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

28 changes: 11 additions & 17 deletions crates/backend/optimizer/path/costsize/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3411,8 +3411,8 @@ pub fn final_cost_nestloop(
ntuples = outer_path_rows * inner_path_rows;
}

let quals = types_pathnodes::relids::pgvec_clone_shallow(run.mcx, &path.jpath.joinrestrictinfo);
let restrict_qual_cost = crate::cost_qual_eval(run, &quals)?;
// `path` is not yet in the arena, so its lists can be passed while `run` is borrowed mutably.
let restrict_qual_cost = crate::cost_qual_eval(run, &path.jpath.joinrestrictinfo)?;
startup_cost += restrict_qual_cost.startup;
let cpu_per_tuple = gucs::cpu_tuple_cost() + restrict_qual_cost.per_tuple;
// mul_add mirrors the C referee's fmadd (GCC fp-contract fuses
Expand Down Expand Up @@ -3597,8 +3597,7 @@ pub fn final_cost_hashjoin(
#[allow(unused_assignments)] // Rust-structural: C declares uninitialized (costsize.c:4294); the by-value seam made this initializer dead
let mut innerbucketsize = 1.0f64;
let mut innermcvfreq = 1.0f64;
let inner_relids = run.root.rel(inner_parent).relids.clone();
let hcls = types_pathnodes::relids::pgvec_clone_shallow(run.mcx, &path.path_hashclauses);
let hcls: &[RinfoId] = &path.path_hashclauses;
let otherclauses = if inner_is_unique_path {
innerbucketsize = 1.0 / virtualbuckets;
innermcvfreq = 0.0;
Expand All @@ -3607,15 +3606,16 @@ pub fn final_cost_hashjoin(
let (other, bs) = planner_seams::estimate_multivariate_bucketsize::call(
run,
inner_parent,
&hcls,
hcls,
)?;
innerbucketsize = bs;
other
};
for &hcl in otherclauses.iter() {
let right_is_inner = {
let r = run.root.rinfo(hcl);
types_pathnodes::relids::relids_is_subset(&r.right_relids, &inner_relids)
let inner_relids = &run.root.rel(inner_parent).relids;
types_pathnodes::relids::relids_is_subset(&r.right_relids, inner_relids)
};
let (thisbucketsize, thismcvfreq) = if right_is_inner {
let cached = run.root.rinfo(hcl).right_bucketsize;
Expand Down Expand Up @@ -3662,10 +3662,8 @@ pub fn final_cost_hashjoin(
startup_cost += DISABLE_COST;
}

let hash_qual_cost = crate::cost_qual_eval(run, &hcls)?;
let joinrestrict =
types_pathnodes::relids::pgvec_clone_shallow(run.mcx, &path.jpath.joinrestrictinfo);
let qp_qual_cost = crate::cost_qual_eval(run, &joinrestrict)?;
let hash_qual_cost = crate::cost_qual_eval(run, hcls)?;
let qp_qual_cost = crate::cost_qual_eval(run, &path.jpath.joinrestrictinfo)?;
let qp_startup = qp_qual_cost.startup - hash_qual_cost.startup;
let qp_per_tuple = qp_qual_cost.per_tuple - hash_qual_cost.per_tuple;

Expand Down Expand Up @@ -4054,12 +4052,8 @@ pub fn final_cost_mergejoin(
path.jpath.path.rows = clamp_row_est(path.jpath.path.rows / parallel_divisor);
}

let mergeclauses =
types_pathnodes::relids::pgvec_clone_shallow(run.mcx, &path.path_mergeclauses);
let restrictinfos =
types_pathnodes::relids::pgvec_clone_shallow(run.mcx, &path.jpath.joinrestrictinfo);
let merge_qual_cost = crate::cost_qual_eval(run, &mergeclauses)?;
let mut qp_qual_cost = crate::cost_qual_eval(run, &restrictinfos)?;
let merge_qual_cost = crate::cost_qual_eval(run, &path.path_mergeclauses)?;
let mut qp_qual_cost = crate::cost_qual_eval(run, &path.jpath.joinrestrictinfo)?;
qp_qual_cost.startup -= merge_qual_cost.startup;
qp_qual_cost.per_tuple -= merge_qual_cost.per_tuple;

Expand All @@ -4070,7 +4064,7 @@ pub fn final_cost_mergejoin(
path.skip_mark_restore =
early_stop && path.jpath.joinrestrictinfo.len() == path.path_mergeclauses.len();

let mergejointuples = approx_tuple_count(run, outer_path, inner_path, &mergeclauses)?;
let mergejointuples = approx_tuple_count(run, outer_path, inner_path, &path.path_mergeclauses)?;

let outer_is_unique_path = matches!(
run.root.path(outer_path),
Expand Down
Loading
Loading