Repository navigation
Fix cross-parity version listing after pool removal - #267
Merged
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Availability-optimized writes can leave a readable null version across separate EC groups when a disk is unavailable. The all-version listing path used by
ListObjectVersions, decommission, and rebalance only re-counted this case for latest-only reads, so a readable object could disappear from version listings and from migration after complete source-pool removal.Change
ListObjectVersionsregression test.Validation
go test ./... -count=1CGO_ENABLED=0 go test ./cmd/ -count=1 -timeout 30mgo test ./cmd -shuffle=on -count=1go vet ./cmdmake verifiersmake buildgit diff --check