Skip to content

test: speed-up Podman tests by forwarding the CI environment variable - #1466

Merged
Ron (rjaegers) merged 1 commit into
mainfrom
test/speed-up-podman-test
Sep 15, 2026
Merged

Ron (rjaegers) merged 1 commit into
mainfrom
test/speed-up-podman-test

Conversation

@rjaegers

Copy link
Copy Markdown
Member

🚀 Hey, I have created a Pull Request

Description of changes

This pull request makes a small update to the workflow configuration to ensure the container environment is aware it's running in CI.

  • Added the CI environment variable to the podman run command in .github/workflows/wc-integration-test-podman.yml to help tools inside the container detect they are running in a continuous integration environment.

✔️ Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM
  • I understand the image size delta and agree the functionality justifies it

Copilot AI lite review requested due to automatic review settings September 15, 2026 07:42
@sonarqubecloud

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused workflow change has no unresolved review issues.

Pull request overview

Updates the Podman integration-test workflow to expose the CI environment inside the container.

Changes:

  • Adds -e CI to the Podman container invocation.
File summaries
File Description
.github/workflows/wc-integration-test-podman.yml Forwards the CI environment variable to integration tests.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-base:edgeghcr.io/philips-software/amp-devcontainer-base:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 87.58 MB 87.58 MB 299 B (0%) 🔽
linux/arm64 85.15 MB 85.15 MB 250 B (0%) 🔽

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

⚠️MegaLinter analysis: Success with warnings

Descriptor Linter Files Fixed Errors Max errors Warnings Elapsed time
✅ ACTION actionlint 23 0 0 0.32s
✅ DOCKERFILE hadolint 4 0 0 0.43s
✅ JSON npm-package-json-lint yes no no 0.54s
✅ JSON prettier 46 8 0 0 0.83s
✅ JSON v8r 46 0 0 14.02s
✅ MARKDOWN markdownlint 13 0 0 0 1.09s
✅ MARKDOWN markdown-table-formatter 13 0 0 0 0.27s
✅ REPOSITORY betterleaks yes no no 1.04s
✅ REPOSITORY checkov yes no no 22.22s
✅ REPOSITORY git_diff yes no no 0.02s
✅ REPOSITORY grype yes no no 84.11s
⚠️ REPOSITORY osv-scanner yes 2 no 1.82s
✅ REPOSITORY secretlint yes no no 2.86s
✅ REPOSITORY syft yes no no 6.31s
✅ REPOSITORY trivy yes no no 13.8s
✅ REPOSITORY trivy-sbom yes no no 0.38s
✅ REPOSITORY trufflehog yes no no 4.28s
⚠️ SPELL lychee 119 1 0 10.68s
✅ YAML prettier 36 0 0 0 2.54s
✅ YAML v8r 36 0 0 12.33s
✅ YAML yamllint 36 0 0 1.32s

Detailed Issues

⚠️ SPELL / lychee - 1 error
📝 Summary
---------------------
🔍 Total..........154
🔗 Unique.........126
✅ Successful.....148
⏳ Timeouts.........0
🔀 Redirected......19
👻 Excluded.........0
❓ Unknown..........0
🚫 Errors...........1
⛔ Unsupported......1

Errors in .github/TOOL_VERSION_ISSUE_TEMPLATE.md
[403] https://developer.arm.com/downloads/-/arm-gnu-toolchain-downloads (at 38:7) | Rejected status code: 403 Forbidden

Hint: Followed 19 redirects. You might want to consider replacing redirecting URLs with the resolved URLs. Use verbose mode (`-v`/`-vv`) to see redirection details.
Hint: You can configure accepted/rejected response codes with `-a` or `--accept`
⚠️ REPOSITORY / osv-scanner - 2 errors
Scanning dir .
Starting filesystem walk for root: /
Scanned .devcontainer/cpp/requirements.txt file and found 20 packages
Scanned .devcontainer/docs/requirements.txt file and found 14 packages
Scanned package-lock.json file and found 73 packages
Scanned test/embedded-rust/workspace/cortex-mf/Cargo.lock file and found 20 packages
Scanned test/embedded-rust/workspace/cortex-m/Cargo.lock file and found 20 packages
Scanned test/rust/workspace/cargo/Cargo.lock file and found 1 package
Scanned test/rust/workspace/clippy/Cargo.lock file and found 1 package
Scanned test/rust/workspace/test/Cargo.lock file and found 1 package
Scanned .github/actions/update-vscode-extensions/package-lock.json file and found 288 packages
End status: 84 dirs visited, 285 inodes visited, 9 Extract calls, 58.774803ms elapsed, 58.775012ms wall time

Total 3 packages affected by 4 known vulnerabilities (0 Critical, 2 High, 0 Medium, 0 Low, 2 Unknown) from 2 ecosystems.
2 vulnerabilities can be fixed.

+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+
| OSV URL                             | CVSS | ECOSYSTEM | PACKAGE               | VERSION | FIXED VERSION | SOURCE                                            |
+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+
| https://osv.dev/RUSTSEC-2026-0110   |      | crates.io | bare-metal            | 0.2.5   | --            | test/embedded-rust/workspace/cortex-m/Cargo.lock  |
| https://osv.dev/RUSTSEC-2026-0110   |      | crates.io | bare-metal            | 0.2.5   | --            | test/embedded-rust/workspace/cortex-mf/Cargo.lock |
| https://osv.dev/GHSA-mh99-v99m-4gvg | 7.5  | npm       | brace-expansion (dev) | 5.0.7   | 5.0.8         | package-lock.json                                 |
| https://osv.dev/GHSA-rgw5-rvv9-x895 | 7.5  | npm       | brace-expansion (dev) | 5.0.7   | 5.0.9         | package-lock.json                                 |
+-------------------------------------+------+-----------+-----------------------+---------+---------------+---------------------------------------------------+

See detailed reports in MegaLinter artifacts

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

  • Documentation: Custom Flavors
  • Command: npx mega-linter-runner@10.0.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,DOCKERFILE_HADOLINT,JSON_V8R,JSON_PRETTIER,JSON_NPM_PACKAGE_JSON_LINT,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_GIT_DIFF,REPOSITORY_BETTERLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is provided by OX Security
Show us your support by starring ⭐ the repository

@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-docs:edgeghcr.io/philips-software/amp-devcontainer-docs:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 219.12 MB 219.12 MB 283 B (0%) 🔽
linux/arm64 214.83 MB 214.83 MB 448 B (0%) 🔽

@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-rust:edgeghcr.io/philips-software/amp-devcontainer-rust:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 443.49 MB 443.49 MB 117 B (0%) 🔽
linux/arm64 393 MB 393 MB 416 B (0%) 🔽

@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-rust:edgeghcr.io/philips-software/amp-devcontainer-embedded-rust:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 510.24 MB 510.24 MB 173 B (0%) 🔽
linux/arm64 459.46 MB 459.46 MB 1.65 kB (0%) 🔽

@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:edgeghcr.io/philips-software/amp-devcontainer-cpp:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 411.65 MB 411.65 MB 1.16 kB (0%) 🔽
linux/arm64 391.69 MB 391.69 MB 96 B (0%) 🔽

@rjaegers
Ron (rjaegers) deployed to acceptance-testing September 15, 2026 07:51 — with GitHub Actions Active
@github-actions

Copy link
Copy Markdown
Contributor

📦 Container Size Analysis

Note

Comparing ghcr.io/philips-software/amp-devcontainer-embedded-cpp:edgeghcr.io/philips-software/amp-devcontainer-embedded-cpp:pr-1466

📈 Size Comparison Table

OS/Platform Previous Current Change Trend
linux/amd64 613.81 MB 613.81 MB +711 B (+0%) 🔼
linux/arm64 593.13 MB 593.13 MB 1.08 kB (0%) 🔽

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

 25 files  ±0   25 suites  ±0   9m 1s ⏱️ - 54m 58s
 53 tests ±0   53 ✅ ±0  0 💤 ±0  0 ❌ ±0 
229 runs  ±0  229 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ec10c88. ± Comparison against base commit 3ebfe7c.

@rjaegers
Ron (rjaegers) added this pull request to the merge queue Sep 15, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 15, 2026
@rjaegers
Ron (rjaegers) added this pull request to the merge queue Sep 15, 2026
Merged via the queue into main with commit d9df46a Sep 15, 2026
81 of 82 checks passed
@rjaegers
Ron (rjaegers) deleted the test/speed-up-podman-test branch September 15, 2026 09:51
@github-actions

Copy link
Copy Markdown
Contributor

Pull Request Report (#1466)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 0
Number of changed files 1
Number of commits 1
Number of reviews 2
Number of comments (w/o review comments) 9
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.1 Hours
Time that was spend on the branch before the PR was created 1.1 Min
Time that was spend on the branch before the PR was merged 2.2 Hours
Time to merge after last review 32.6 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 1.4 Hours
Total time spend in last status check run on PR 1.4 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants