Repository navigation
Fix Heap iterator value ownership and rewinding - #235
Merged
rtheunissen merged 1 commit intoOct 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #234.
The underlying Heap iterator bugs predated #234, but returning
InternalIteratorexposed them through directcurrent(),key(), andrewind()calls. Ordinaryforeachchecksvalid()before reading values or keys and creates a fresh iterator for each loop, which hid these cases.This fixes value ownership and rewinding, and returns
nullfor empty or exhausted iterators.Repeated
current()calls no longer access freed objects:Rewinding restarts the same iterator:
Empty or exhausted iterators now return
nullfromcurrent()andkey(). Callingnext()orrewind()on the same iterator from its comparator throwsRuntimeExceptionto prevent use-after-free.