Repository navigation
Conversation
HypeMC
force-pushed
the
fix-heap-comparator-isolation
branch
from
October 13, 2026 09:00
2a0bff9 to
cff6df2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heap operations shared callback state, so using another heap during iteration or inside a comparator could cause incorrect ordering. Pass the owning heap into comparisons and keep callback invocation state local.
This bug predates #234 and already affected ordinary
foreach. ReturningInternalIteratoradded another way to encounter it through interleaved iterators.For example:
Before:
[1,2,5,4,3]After:
[1,2,3,4,5]