Skip to content

feat(ui): expose captured trace totals and style clickable Log severity counters as filter pills alongside History status shortcuts. - #32

Merged
terabytesoftw merged 2 commits into
mainfrom
feat/expose-captured-trace-totals
Sep 3, 2026
Merged

feat(ui): expose captured trace totals and style clickable Log severity counters as filter pills alongside History status shortcuts.#32
terabytesoftw merged 2 commits into
mainfrom
feat/expose-captured-trace-totals

Conversation

@terabytesoftw

Copy link
Copy Markdown
Contributor

Pull Request

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bugfix (non-breaking change that fixes an issue)
  • CI/build configuration
  • Documentation update
  • New feature (non-breaking change that adds functionality)
  • Refactoring (no functional changes)

…ty counters as filter pills alongside History status shortcuts.
@terabytesoftw terabytesoftw added the enhancement New feature or request label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (78cf264) to head (f240571).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##                main       #32   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity      1745      1747    +2     
===========================================
  Files            141       141           
  Lines           7053      7062    +9     
===========================================
+ Hits            7053      7062    +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

Next included review available in 51 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: 14528739-f837-454e-9d55-8d08b14a699f

📥 Commits

Reviewing files that changed from the base of the PR and between 9802f55 and f240571.

📒 Files selected for processing (1)
  • tests/Panel/Log/LogCountsTest.php

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: f6b2af0f-73a7-4051-9624-f5c956f14543

📥 Commits

Reviewing files that changed from the base of the PR and between 78cf264 and 9802f55.

⛔ Files ignored due to path filters (1)
  • resources/assets/dist/css/debug.min.css is excluded by !**/dist/**, !**/*.min.css
📒 Files selected for processing (4)
  • CHANGELOG.md
  • resources/src/styles/main.css
  • src/Panel/Log/LogCounts.php
  • tests/Panel/Log/LogCountsTest.php

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: phpunit / PHP 8.5-windows-2022
  • GitHub Check: phpunit / PHP 8.3-windows-2022
  • GitHub Check: phpunit / PHP 8.4-windows-2022
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
  • GitHub Check: Verify Vite build reproduces dist.
  • GitHub Check: mutation / PHP 8.5-ubuntu-latest
🧰 Additional context used
🪛 PHPMD (2.15.0)
tests/Panel/Log/LogCountsTest.php

[error] 60-60: Avoid using static access to class '\PHPForge\Debug\Panel\Log\LogCounts' in method 'testFromRowsExposesHasFlagsForNonZeroCounts'. (undefined)

(StaticAccess)

🔇 Additional comments (4)
src/Panel/Log/LogCounts.php (1)

33-36: LGTM!

Also applies to: 49-67, 86-92

tests/Panel/Log/LogCountsTest.php (1)

51-60: LGTM!

Also applies to: 74-77, 101-120

resources/src/styles/main.css (1)

2035-2035: LGTM!

Also applies to: 2686-2701, 2711-2713, 2732-2735

CHANGELOG.md (1)

38-38: LGTM!


📝 Summary

Summary by CodeRabbit

  • New Features

    • Log summaries now include captured trace-level message totals.
    • Log severity counters are presented as clickable filters, making it easier to focus on errors, warnings, informational messages, or traces.
    • History status shortcuts and Log filters are available together for faster navigation.
  • Documentation

    • Updated guidance explains navigation between messages and using Log-level filters alongside History status buckets.

Walkthrough

The change adds TRACE totals and presence checks to LogCounts. It adds coverage for trace aggregation and defaults. It also styles Log severity counters as clickable filter pills and updates related documentation and changelog text.

Changes

Trace Counts and Log Filters

Layer / File(s) Summary
Trace count aggregation and validation
src/Panel/Log/LogCounts.php, tests/Panel/Log/LogCountsTest.php
LogCounts counts TRACE messages, exposes hasTrace(), and keeps the trace count at zero for default construction. Tests cover aggregation and presence flags.
Log summary filter styling
resources/src/styles/main.css, CHANGELOG.md
Log severity counters receive hue classes and clickable pill selectors. Documentation and the changelog describe trace totals, severity filters, and inter-message navigation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 9802f

This change adds trace totals to Log summaries and styles severity counters as filter pills while preserving existing construction compatibility. No current merge-blocking risk remains.

Poem

A rabbit counts each trace with care
Warning and info pills glow there
Errors hop into the view
History shortcuts join them too
The changelog twinkles, fresh and bright

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main feature: exposing trace totals and styling clickable Log severity counters. It is specific and related to the changeset.
Description check ✅ Passed The description identifies the change as a non-breaking new feature, which matches the pull request objectives and changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 2 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/expose-captured-trace-totals

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@terabytesoftw
terabytesoftw merged commit eadd354 into main Sep 3, 2026
43 checks passed
@terabytesoftw
terabytesoftw deleted the feat/expose-captured-trace-totals branch September 3, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant