[Sync-EN] Clarify the Argon2 memory_cost and time_cost units - #1788
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Clarify the Argon2 memory_cost and time_cost units#1788lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
reference/password/constants.xmlandreference/password/functions/password-hash.xmlwith php/doc-en#5219.PASSWORD_ARGON2_DEFAULT_MEMORY_COSTis documented in kibibytes, not bytes.time_costandPASSWORD_ARGON2_DEFAULT_TIME_COSTare a number of iterations (passes), not a time limit. Both pages said "maximum amount of time", which described neither the unit nor the behaviour.PASSWORD_BCRYPT_DEFAULT_COSThad two empty paragraphs; it is now described as the default algorithmic cost used bypassword_hash()withPASSWORD_BCRYPT, available as of PHP 7.0.0.EN-Revision bumped to 6cc48aed6f887bdabf09c568f854099f9c74e017 on both files.
Fixes: #1620