[Sync-EN] Document boolean support for allowed_classes in unserialize() - #1789
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Document boolean support for allowed_classes in unserialize()#1789lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs
appendices/migration84/incompatible.xmlandreference/var/functions/unserialize.xmlwith php/doc-en#4768 and php/doc-en#5797.php/doc-en#4768: the 8.4.0
allowed_classesrule is stated correctly on both pages. It throws when the value is neither an array of class names nor a bool; the previous wording implied a bool was rejected too, whiletrueandfalseare the documented ways to allow all or no classes.php/doc-en#5797, on the migration page's MBString section:
mb_strstr()as well asmb_substr().SJIS-macparagraph is rewritten to say those indices differ from theSJIS-maccharacter indices for characters converting to several codepoints, instead of the vaguer "about 40 characters" remark.EN-Revision bumped per file to the last upstream commit touching it.
Fixes: #1639