[Sync-EN] Fix the Uri\WhatWg\Url screens that ignore URL normalization - #1793
Open
lacatoire wants to merge 1 commit into
Open
[Sync-EN] Fix the Uri\WhatWg\Url screens that ignore URL normalization#1793lacatoire wants to merge 1 commit into
lacatoire wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs the three
reference/uri/uri/whatwg/url/pages with php/doc-en#5721.The example outputs did not match what the code actually prints, because they ignored WHATWG URL normalization:
getPort(): the example usedhttps://example.com:443and claimed it prints443. 443 is the default port for https, so it is not stored andgetPort()returnsnull. The example now shows both cases, withvar_dump().withPort(): same problem;withPort(443)on an https URL yieldsnull, and a second call with 8443 shows a non-default port being kept.parse():toAsciiString()onhttps://example.comprintshttps://example.com/, with the normalized trailing slash.EN-Revision bumped to 0e06411471a898974e114bd57f624781fe3a0b89 on the three files.
Fixes: #1610